create e2e coverage on medik8s-5.0 branch - #84028
Conversation
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe pull request adds CI configurations for the Medik8s Node Healthcheck Operator on OpenShift 4.23 and the 5.0 branch. The configurations define builds, bundles, releases, unit tests, AWS end-to-end workflows, and optional TLS validation workflows. ChangesNode Healthcheck Operator CI
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds end-to-end CI coverage for the medik8s 5.0 branch, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Full details: Stable And Deterministic Test NamesExplanation The pull request adds CI YAML and generated Prow job YAML only. The added files contain static CI step names such as Full details: Test Structure And QualityExplanation PASS — The pull request changes only CI YAML and generated Prow job metadata. It adds shell commands that invoke Full details: Microshift Test CompatibilityExplanation PASS — The pull request adds only CI YAML and generated Prow job files. The exact commit diff contains no Go or other Ginkgo test source, no It/Describe/Context/When declarations, and no MicroShift guards or API tags to assess. The new workflow only invokes existing targets such as Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds only CI YAML configuration and generated Prow jobs. The diff contains no new Ginkgo test declarations or test source. The Full details: Topology-Aware Scheduling CompatibilityExplanation PASS. The commit adds only two ci-operator configuration files and one generated Prow presubmit job file. These files define CI builds, tests, workflows, and CI job resources; they do not add or modify operator code, controllers, or deployment manifests. The additions contain no required/preferred affinity, topology spread constraints, node selectors or affinity, tolerations, replica derivation, or PDB settings. Therefore, no explicit topology-unsafe scheduling condition is introduced. Full details: Ote Binary Stdout ContractExplanation PASS: The commit adds only CI configuration and generated Prow job YAML. It adds no Go or OTE source code and no process-level stdout calls. The new 4.23 and 5.0 configurations match the existing main configurations except for the branch metadata. Their test commands delegate to Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The commit adds only CI configuration and generated Prow job YAML. It adds no Go or other test source files and no new Ginkgo declarations such as Full details: No-Weak-CryptoExplanation No weak-crypto usage is introduced. The pull request adds CI YAML and generated Prow jobs only. Exact added-line scans found no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB references. The TLS scanner and TLS 1.3/PQC workflow references configure security tests; they do not implement cryptography. The generated job secrets are CI credential mounts, with no secret or token comparison. Full details: Container-PrivilegesExplanation The pull request adds two CI configuration files and one generated Prow job file. None contains Full details: No-Sensitive-Data-In-LogsExplanation No sensitive-data logging was introduced. The pull request adds CI YAML and generated Prow job definitions. Their command blocks invoke tests and operator installation, but do not print passwords, tokens, API keys, PII, session IDs, or customer data. Secret mounts are standard CI infrastructure references and expose no values. The TLS scanner and failure-analyzer steps contain logging, but those reusable step implementations are unchanged; the new configuration only references them, consistent with the existing Node Healthcheck 5.0 configuration. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@weshayutin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2 participants
Summary by CodeRabbit
Adds OpenShift CI coverage for the Medik8s Node Healthcheck Operator 5.0 branch. The configuration supports UBI builds, bundle generation, nightly releases, unit tests, and AWS end-to-end workflows for installation, upgrades, readiness, and TLS checks.