fix(hypershift): remove unused VolumeSnapshotLocation in OADP setup for Agent/Kubevirt - #83883
fix(hypershift): remove unused VolumeSnapshotLocation in OADP setup for Agent/Kubevirt#83883mgencur wants to merge 1 commit into
Conversation
Removes VolumeSnapshotLocation resource creation from OADP v2 setup step for hypershift, simplifying the configuration. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe OADP v2 setup script no longer creates or applies a ChangesOADP v2 setup
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a localized configuration simplification that removes an unused resource from the OADP setup; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mgencur: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Setup failing due to https://redhat.atlassian.net/browse/OCPBUGS-112342 , need to re-run after merging the related PR with the fix. |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 participant
Removes VolumeSnapshotLocation resource creation from OADP v2 setup step for hypershift, simplifying the configuration.
Related to discussion in this thread
Summary by CodeRabbit
The Hypershift Agent/Kubevirt OADP v2 CI setup no longer creates the unused
VolumeSnapshotLocationresource. The setup now creates theBackupStorageLocationand waits for the required resources to become ready.