Skip to content

openshift-mcp-server: establish CI pass gates - #82846

Open
grokspawn wants to merge 1 commit into
openshift:mainfrom
grokspawn:vertex-pass-gates
Open

openshift-mcp-server: establish CI pass gates#82846
grokspawn wants to merge 1 commit into
openshift:mainfrom
grokspawn:vertex-pass-gates

Conversation

@grokspawn

@grokspawn grokspawn commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

build off #81118 and establish 80% pass gates for the jobs

Summary by CodeRabbit

The OpenShift CI configuration now enforces 80% task and assertion pass-rate gates for the Google and Anthropic MCP checker evaluation tests.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The MCP server CI configuration sets TASK_PASS_RATE and ASSERTION_PASS_RATE to 0.8 for Google and Anthropic evaluation tests.

Changes

MCP evaluation thresholds

Layer / File(s) Summary
Configure evaluation thresholds
ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-main.yaml
The Google and Anthropic evaluation tests now set task and assertion pass-rate thresholds to 0.8.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: dlom, 2uasimojo

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch only adds static 0.8 environment values to one YAML manifest; it adds no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality ✅ Passed PASS: The PR changes only one CI YAML file and adds pass-rate variables; it contains no Ginkgo It blocks or cluster test setup, waits, or assertions to review.
Microshift Test Compatibility ✅ Passed The commit changes only CI YAML environment variables; it adds no Ginkgo e2e tests or OpenShift API/resource references requiring MicroShift checks.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only one CI YAML file, adding pass-rate environment variables; it adds no Ginkgo e2e tests or node-topology assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The patch only adds two CI environment variables to MCP evaluation tests; it introduces no deployment, controller, replica, affinity, topology, selector, taint, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only one CI YAML file, adding pass-rate environment variables; it adds no OTE binary, suite setup, logging, or stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only one CI YAML file, adding pass-rate variables to two existing checker jobs; it adds no Ginkgo tests or new network connectivity code.
No-Weak-Crypto ✅ Passed The HEAD diff adds only four YAML pass-rate variables with value 0.8; it adds no cryptographic algorithm, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed The commit adds only four pass-rate environment entries; the changed manifest and referenced CI chain contain no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds only numeric TASK_PASS_RATE and ASSERTION_PASS_RATE environment values; it adds no logging and no sensitive data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: adding pass gates (via environment variables) to CI configuration for the openshift-mcp-server project.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from 2uasimojo and dlom August 3, 2026 20:30
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@grokspawn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-anthropic openshift/openshift-mcp-server presubmit Ci-operator config changed
pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-google openshift/openshift-mcp-server presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Signed-off-by: grokspawn <jordan@nimblewidget.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@grokspawn: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@dlom

dlom commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dlom, grokspawn
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-anthropic
/pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-google

@grokspawn grokspawn changed the title establish pass gates openshift-mcp-server: establish CI pass gates Aug 4, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@grokspawn: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@grokspawn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-anthropic
/pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-google

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@grokspawn: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@grokspawn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-google

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@grokspawn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@grokspawn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/openshift-mcp-server/main/mcpchecker-eval-anthropic 98a0581 link unknown /pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-anthropic
ci/rehearse/openshift/openshift-mcp-server/main/mcpchecker-eval-google 98a0581 link unknown /pj-rehearse pull-ci-openshift-openshift-mcp-server-main-mcpchecker-eval-google

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants