Skip to content

WIP: System compressible test#30935

Draft
ngopalak-redhat wants to merge 3 commits intoopenshift:mainfrom
ngopalak-redhat:ngopalak/system_compressible
Draft

WIP: System compressible test#30935
ngopalak-redhat wants to merge 3 commits intoopenshift:mainfrom
ngopalak-redhat:ngopalak/system_compressible

Conversation

@ngopalak-redhat
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d4026810-d2f4-4747-8f9c-8c770d69a370

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ngopalak-redhat
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aa851090-28cd-11f1-82f1-cdef52eb2ea7-0

@ngopalak-redhat
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/42b1e890-28ea-11f1-8d5b-2e6d61b26fdc-0

o.Expect(err).NotTo(o.HaveOccurred(), "Should collect CPU usage samples")

// Verify CPU stays <= 500m (allow 3 samples to exceed for transient spikes)
err = verifyCPULimit(samples, 500.0, 3)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4 vCPU, it is 517.6 according to system slice cores calculated by weights. https://docs.google.com/spreadsheets/d/1FbSBnG4NGk9te3xiWZ2D9BF9DG_F_GPVp5mTVE6PsDg/

Suggested change
err = verifyCPULimit(samples, 500.0, 3)
err = verifyCPULimit(samples, 517.6, 3)


g.It("should enforce system compressible CPU limit by default", func(ctx context.Context) {
// Select node with >= 4 CPUs
nodeName, err := selectTestNode(ctx, oc, 4)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the settings for the createCPULoadInSlice, createCPULoadInSlice and verifyCPULimit are all for 4vCPU now, here we need to choose a fixed cpu number as 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants