WIP: System compressible test#30935
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ngopalak-redhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aa851090-28cd-11f1-82f1-cdef52eb2ea7-0 |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning |
|
@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/42b1e890-28ea-11f1-8d5b-2e6d61b26fdc-0 |
| o.Expect(err).NotTo(o.HaveOccurred(), "Should collect CPU usage samples") | ||
|
|
||
| // Verify CPU stays <= 500m (allow 3 samples to exceed for transient spikes) | ||
| err = verifyCPULimit(samples, 500.0, 3) |
There was a problem hiding this comment.
For 4 vCPU, it is 517.6 according to system slice cores calculated by weights. https://docs.google.com/spreadsheets/d/1FbSBnG4NGk9te3xiWZ2D9BF9DG_F_GPVp5mTVE6PsDg/
| err = verifyCPULimit(samples, 500.0, 3) | |
| err = verifyCPULimit(samples, 517.6, 3) |
|
|
||
| g.It("should enforce system compressible CPU limit by default", func(ctx context.Context) { | ||
| // Select node with >= 4 CPUs | ||
| nodeName, err := selectTestNode(ctx, oc, 4) |
There was a problem hiding this comment.
As the settings for the createCPULoadInSlice, createCPULoadInSlice and verifyCPULimit are all for 4vCPU now, here we need to choose a fixed cpu number as 4.
No description provided.