Skip to content

NE-2131: register CIO tests extension and remove tests migrated to CIO#30911

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
lihongan:ote-for-cio-test
Mar 29, 2026
Merged

NE-2131: register CIO tests extension and remove tests migrated to CIO#30911
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
lihongan:ote-for-cio-test

Conversation

@lihongan
Copy link
Copy Markdown

@lihongan lihongan commented Mar 20, 2026

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 20, 2026

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from miheer and p0lyn0mial March 20, 2026 09:41
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aaa878ad-d2ce-4213-94b2-c6069314fc86

📥 Commits

Reviewing files that changed from the base of the PR and between 3318a72 and 647500f.

📒 Files selected for processing (2)
  • pkg/test/extensions/binary.go
  • test/extended/router/gatewayapi.go
💤 Files with no reviewable changes (1)
  • test/extended/router/gatewayapi.go

Walkthrough

Added a new cluster-ingress-operator entry to the extension binaries registry mapping to an external binary path. Removed an entire Gateway API router CRD governance test suite that verified CRD constraints through deletion, update, and creation attempts.

Changes

Cohort / File(s) Summary
Binary Extension Registry
pkg/test/extensions/binary.go
Added new registry entry for cluster-ingress-operator image tag mapping to /usr/bin/cluster-ingress-operator-tests-ext.gz external binary path.
Deleted Gateway API Test Suite
test/extended/router/gatewayapi.go
Removed entire Ginkgo test specification that validated Gateway API CRD governance, including CRD existence verification, deletion/update/creation rejection assertions, and helper function buildGWAPICRDFromName() for constructing minimal CRD objects.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@lihongan lihongan changed the title NE-2131: register CIO tests extension NE-2131: register CIO tests extension and remove tests migrated to CIO Mar 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 20, 2026

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Follow up openshift/cluster-ingress-operator#1371

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lihongan
Copy link
Copy Markdown
Author

/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@lihongan
Copy link
Copy Markdown
Author

/retest-required

@lihongan
Copy link
Copy Markdown
Author

/verified by e2e

Checked the e2e and the migrated 5 tests passed and tests name remain unchanged

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@lihongan: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Checked the e2e and the migrated 5 tests passed and tests name remain unchanged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lihongan
Copy link
Copy Markdown
Author

cc @rikatz

@rikatz
Copy link
Copy Markdown
Member

rikatz commented Mar 24, 2026

/lgtm
/approve
🚀

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@neisw
Copy link
Copy Markdown
Contributor

neisw commented Mar 26, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lihongan, neisw, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 54062fe and 2 for PR HEAD 647500f in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD a209706 and 1 for PR HEAD 647500f in total

@lihongan
Copy link
Copy Markdown
Author

/retest-required

Step e2e-vsphere-ovn-upi-upi-conf-vsphere-vcm failed

no enough addresses

@lihongan
Copy link
Copy Markdown
Author

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD e368054 and 0 for PR HEAD 647500f in total

@rikatz
Copy link
Copy Markdown
Member

rikatz commented Mar 27, 2026

/retest-required

@rikatz
Copy link
Copy Markdown
Member

rikatz commented Mar 27, 2026

a heads up: the job e2e-vsphere-ovn-upi is failing since yesterday in the morning

@openshift-trt
Copy link
Copy Markdown

openshift-trt Bot commented Mar 27, 2026

Job Failure Risk Analysis for sha: 647500f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (20) are below the historical average (3230): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link
Copy Markdown

/hold

Revision 647500f was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2026
@lihongan
Copy link
Copy Markdown
Author

/test e2e-vsphere-ovn-upi

@lihongan
Copy link
Copy Markdown
Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 29, 2026

@lihongan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 31582ab into openshift:main Mar 29, 2026
21 checks passed
@lihongan
Copy link
Copy Markdown
Author

lihongan commented Apr 2, 2026

Change included in accepted release 4.22.0-0.nightly-2026-04-01-092906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants