Skip to content

[release-4.22] OCPBUGS-101982: Replace golang.org/x/net with github.com/openshift-sustaining/net v0.50.0-sec.4 - #220

Open
atewari-rh wants to merge 1 commit into
openshift:release-4.22from
atewari-rh:CVE-2026-33814-2026
Open

[release-4.22] OCPBUGS-101982: Replace golang.org/x/net with github.com/openshift-sustaining/net v0.50.0-sec.4#220
atewari-rh wants to merge 1 commit into
openshift:release-4.22from
atewari-rh:CVE-2026-33814-2026

Conversation

@atewari-rh

Copy link
Copy Markdown

https://issues.redhat.com/browse/OCPBUGS-101982
Replace golang.org/x/net with the sustaining fork so we pick up CVE-2026-33814 without moving this repo off Go 1.24.

Why a replace

Upstream fixed CVE-2026-33814 in golang.org/x/net v0.53.0, which requires Go 1.25. oauth-apiserver on release-4.22 is go 1.24.0. A straight go get would force a toolchain bump. The fork backports the patch onto the v0.50.0 / Go 1.24 line (same approach as cluster-ingress-operator#1554 and vmware-vsphere-csi-driver#195).

Vulnerability

CVE-2026-33814: a crafted HTTP/2 SETTINGS frame with SETTINGS_MAX_FRAME_SIZE=0 can send the transport into an infinite CONTINUATION write loop (DoS). This component serves HTTPS through k8s.io/apiserver, which imports golang.org/x/net/http2, so the vulnerable code is on the serving path.

v0.50.0-sec.4 is cumulative on this line, so it also carries:

What changed

  • go.mod / go.sum: replace + checksums
  • vendor/: re-vendor golang.org/x/net from the fork. go mod tidy also refreshed vendored golang.org/x/{sys,text,tools,sync,term} as a resolution side effect — no extra replaces, no operator code.

Go toolchain stays 1.24.0. No API / OAuth token / CLI behavior change.

…m/openshift-sustaining/net v0.50.0-sec.4

Signed-off-by: atewari <atewari@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@atewari-rh: This pull request references Jira Issue OCPBUGS-101982, which is invalid:

  • expected Jira Issue OCPBUGS-101982 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-101982
Replace golang.org/x/net with the sustaining fork so we pick up CVE-2026-33814 without moving this repo off Go 1.24.

Why a replace

Upstream fixed CVE-2026-33814 in golang.org/x/net v0.53.0, which requires Go 1.25. oauth-apiserver on release-4.22 is go 1.24.0. A straight go get would force a toolchain bump. The fork backports the patch onto the v0.50.0 / Go 1.24 line (same approach as cluster-ingress-operator#1554 and vmware-vsphere-csi-driver#195).

Vulnerability

CVE-2026-33814: a crafted HTTP/2 SETTINGS frame with SETTINGS_MAX_FRAME_SIZE=0 can send the transport into an infinite CONTINUATION write loop (DoS). This component serves HTTPS through k8s.io/apiserver, which imports golang.org/x/net/http2, so the vulnerable code is on the serving path.

v0.50.0-sec.4 is cumulative on this line, so it also carries:

  • CVE-2026-39821 (idna)
  • CVE-2026-25681 (html)
  • CVE-2026-27136 (html)

What changed

  • go.mod / go.sum: replace + checksums
  • vendor/: re-vendor golang.org/x/net from the fork. go mod tidy also refreshed vendored golang.org/x/{sys,text,tools,sync,term} as a resolution side effect — no extra replaces, no operator code.

Go toolchain stays 1.24.0. No API / OAuth token / CLI behavior change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f788904d-629a-49a9-b1e9-c4f4fd3bbcfe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from benluddy and p0lyn0mial August 30, 2026 08:19
@openshift-ci

openshift-ci Bot commented Aug 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 30, 2026

Copy link
Copy Markdown

Hi @atewari-rh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2026
@atewari-rh

Copy link
Copy Markdown
Author

/ok-to-test

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown

@atewari-rh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants