[release-4.22] OCPBUGS-101982: Replace golang.org/x/net with github.com/openshift-sustaining/net v0.50.0-sec.4 - #220
Conversation
…m/openshift-sustaining/net v0.50.0-sec.4 Signed-off-by: atewari <atewari@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@atewari-rh: This pull request references Jira Issue OCPBUGS-101982, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @atewari-rh. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@atewari-rh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/OCPBUGS-101982
Replace
golang.org/x/netwith the sustaining fork so we pick up CVE-2026-33814 without moving this repo off Go 1.24.Why a replace
Upstream fixed CVE-2026-33814 in
golang.org/x/netv0.53.0, which requires Go 1.25.oauth-apiserveronrelease-4.22isgo 1.24.0. A straightgo getwould force a toolchain bump. The fork backports the patch onto the v0.50.0 / Go 1.24 line (same approach as cluster-ingress-operator#1554 and vmware-vsphere-csi-driver#195).Vulnerability
CVE-2026-33814: a crafted HTTP/2
SETTINGSframe withSETTINGS_MAX_FRAME_SIZE=0can send the transport into an infinite CONTINUATION write loop (DoS). This component serves HTTPS throughk8s.io/apiserver, which importsgolang.org/x/net/http2, so the vulnerable code is on the serving path.v0.50.0-sec.4is cumulative on this line, so it also carries:idna)html)html)What changed
go.mod/go.sum: replace + checksumsvendor/: re-vendorgolang.org/x/netfrom the fork.go mod tidyalso refreshed vendoredgolang.org/x/{sys,text,tools,sync,term}as a resolution side effect — no extra replaces, no operator code.Go toolchain stays
1.24.0. No API / OAuth token / CLI behavior change.