[release-4.19] OCPBUGS-88355: sync deps for release-4.19 and go build image tags with ART build - #209
Conversation
- Bump Go version from 1.22 to 1.23
- Bump Kubernetes deps from 1.31.1 to 1.32.1
- Update OpenShift deps to release-4.19 branches
- Update kubernetes-apiserver fork to openshift-apiserver-4.19-kubernetes-1.32.1
- Adapt to Go 1.23 API changes: PostStartHookContext.StopCh replaced
with embedded context.Context, unexported fake client types,
utilversion moved to k8s.io/component-base/version
- Update CI build images and Dockerfile
Signed-off-by: Venkata Charan Sunku <vsunku@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test e2e-component |
Signed-off-by: Venkata Charan Sunku <vsunku@redhat.com>
|
/retitle [release-4.19] OCPBUGS-88355: sync deps for release-4.19 and go build image tags with ART build |
|
@sunku5494: This pull request references Jira Issue OCPBUGS-88355, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sanchezl
left a comment
There was a problem hiding this comment.
Did you mean to check in the _output/ dir?
Signed-off-by: Venkata Charan Sunku <vsunku@redhat.com>
Signed-off-by: Venkata Charan Sunku <vsunku@redhat.com>
0ed2c07 to
10a0cc7
Compare
|
@sunku5494: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label jira/skip-dependent-bug-check |
|
@sunku5494: This pull request references Jira Issue OCPBUGS-88355, which is valid. The bug has been moved to the POST state. 4 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sanchezl
left a comment
There was a problem hiding this comment.
LGTM — clean dep sync. All k8s 1.32 API adaptations (PostStartHookContext.Done(), utilversion move, unexported fake types, field selector error string) are correct. Previous _output/ concern addressed. CI all green.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by CI |
|
@sunku5494: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sync deps and build images for release-4.19