Skip to content

NO-JIRA: Add missing build-args-file to bundle-4-23 pipelines#2458

Open
pacevedom wants to merge 1 commit into
openshift:mainfrom
pacevedom:fix-tekton-pipelines-main
Open

NO-JIRA: Add missing build-args-file to bundle-4-23 pipelines#2458
pacevedom wants to merge 1 commit into
openshift:mainfrom
pacevedom:fix-tekton-pipelines-main

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom commented May 29, 2026

The Konflux auto-generated pipeline files for lvm-operator-bundle-4-23 were missing the build-args-file parameter, causing OPERATOR_VERSION and other build args from release/container-build.args to not be passed to buildah. This resulted in empty version strings and a failed operator-sdk generate bundle call.

Summary by CodeRabbit

  • Chores
    • Added CI/CD pipeline configurations for automated building and testing of the lvm-operator bundle on pull requests and push events.

The Konflux auto-generated pipeline files for lvm-operator-bundle-4-23
were missing the build-args-file parameter, causing OPERATOR_VERSION
and other build args from release/container-build.args to not be passed
to buildah. This resulted in empty version strings and a failed
operator-sdk generate bundle call.
@openshift-ci-robot
Copy link
Copy Markdown

@pacevedom: This pull request explicitly references no jira issue.

Details

In response to this:

The Konflux auto-generated pipeline files for lvm-operator-bundle-4-23 were missing the build-args-file parameter, causing OPERATOR_VERSION and other build args from release/container-build.args to not be passed to buildah. This resulted in empty version strings and a failed operator-sdk generate bundle call.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2ffeb9f1-91f0-43a2-a3b6-bc2b72a75d18

📥 Commits

Reviewing files that changed from the base of the PR and between 975cba4 and d3e0f42.

📒 Files selected for processing (2)
  • .tekton/lvm-operator-bundle-4-23-pull-request.yaml
  • .tekton/lvm-operator-bundle-4-23-push.yaml

Walkthrough

Two new Tekton PipelineRun manifests add automated build and publish workflows for the lvm-operator-bundle. The PR pipeline triggers on pull requests; the push pipeline triggers on commits to main. Both configure the same task chain—clone, prefetch dependencies, build image, create index, optionally build source image, run security/scanning tasks, apply tags, push artifacts, and scan RPM signatures—with parameter-driven customization and conditional gating via skip-checks.

Changes

CI/CD Pipelines for lvm-operator-bundle

Layer / File(s) Summary
PR Build Pipeline
.tekton/lvm-operator-bundle-4-23-pull-request.yaml
Tekton PipelineRun for pull-request builds with metadata, build parameters (source, image output, expiration), pipelineSpec (parameters, results, full task chain), optional workspaces (git auth, netrc), and service account configuration.
Push Build Pipeline
.tekton/lvm-operator-bundle-4-23-push.yaml
Tekton PipelineRun for push-to-main builds with metadata, build parameters (hermetic, prefetch, caching, SAST targets), pipelineSpec (parameters, results, task chain with conditional security checks), optional workspaces, and service account configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

ready-for-human-review

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding the missing build-args-file parameter to the bundle-4-23 pipelines, which directly addresses the core issue documented in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds only Tekton YAML pipeline configuration files (no Go test code); Ginkgo test naming check is not applicable.
Test Structure And Quality ✅ Passed PR contains only Tekton YAML pipeline configuration files, not Ginkgo test code. Custom check for test structure/quality is not applicable.
Microshift Test Compatibility ✅ Passed PR adds only Tekton pipeline YAML files, not Ginkgo e2e tests. MicroShift compatibility check only applies to new test code, making it not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only Tekton PipelineRun YAML files, not Ginkgo e2e tests. The SNO test compatibility check applies only to new e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed Added files are Tekton PipelineRun manifests (CI/CD pipelines), not deployment manifests or controllers. They contain no pod scheduling constraints or topology-related directives.
Ote Binary Stdout Contract ✅ Passed PR adds only Tekton YAML pipeline configuration files, not Go code. OTE Binary Stdout Contract check applies only to process-level code (main(), init(), etc.) in binaries, not declarative YAML.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests added. PR only modifies Tekton pipeline YAML files (.tekton/lvm-operator-bundle-4-23-*.yaml) for build infrastructure.
No-Weak-Crypto ✅ Passed PR adds Tekton YAML pipeline configs with no cryptographic implementations or weak algorithms. SHA256 refs are container image digests only.
Container-Privileges ✅ Passed No privileged container configurations found; privileged-nested defaults to "false", no securityContext or hostPID/Network/IPC settings present.
No-Sensitive-Data-In-Logs ✅ Passed Tekton PipelineRun files properly handle secrets via workspaces and don't expose passwords, tokens, keys, or PII in logging or environment variables.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from eggfoobar and jaypoulz May 29, 2026 07:48
@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2026
@coderabbitai coderabbitai Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 29, 2026
@pacevedom
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants