Add active maintainers to under-owned OWNERS files - #2427
Conversation
Several directories list only owners who are no longer active, so Prow suggests reviewers and approvers who do not respond. Add active contributors based on recent contribution history: - sanchezl: crypto, operator/certrotation, operator/apiserver, operator/configobserver/apiserver, operator/staticpod, authentication, authorization, security, and root plus pkg/operator - ibihim: authentication, authorization, oauth (approver); crypto and operator/certrotation (reviewer) - ardaguclu: root, pkg/operator, operator/apiserver This is an additive change only; cleanup of inactive owners is left for a separate PR.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (11)
WalkthroughThe pull request updates the root and package-level OWNERS files with additional reviewers and approvers. ChangesOWNERS updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change adds active maintainers to repository ownership files without removing existing owners or changing product behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sanchezl: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified bypass |
|
@sanchezl: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @bertinatto |
What
Adds active contributors to several
OWNERSfiles whose currently listedowners are largely inactive. No owners are removed in this PR.
Why
A number of directories list only owners who are no longer active. Because
none of these directories set
no_parent_owners, PRs are not blocked (parentapprovers still apply), but Prow suggests reviewers and approvers who no longer
respond, and domain expertise is not represented. This backfills active
maintainers based on recent contribution history.
Changes
/(root)pkg/operator/pkg/operator/apiserver/pkg/operator/configobserver/apiserver/pkg/operator/staticpod/pkg/crypto/pkg/operator/certrotation/pkg/authentication/pkg/authorization/pkg/oauth/pkg/security/ibihimis already a reviewer in the auth directories; this promotes them toapprover there.
ardagucluis already an approver in the encryptiondirectories, so those are unchanged.
Cleanup of inactive owners (via
emeritus_approvers) is intentionally left fora separate PR.
/cc @ibihim @ardaguclu please ack being added as owners.
Summary by CodeRabbit