Skip to content

Add active maintainers to under-owned OWNERS files - #2427

Open
sanchezl wants to merge 1 commit into
openshift:masterfrom
sanchezl:add-active-owners
Open

Add active maintainers to under-owned OWNERS files#2427
sanchezl wants to merge 1 commit into
openshift:masterfrom
sanchezl:add-active-owners

Conversation

@sanchezl

@sanchezl sanchezl commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

What

Adds active contributors to several OWNERS files whose currently listed
owners are largely inactive. No owners are removed in this PR.

Why

A number of directories list only owners who are no longer active. Because
none of these directories set no_parent_owners, PRs are not blocked (parent
approvers still apply), but Prow suggests reviewers and approvers who no longer
respond, and domain expertise is not represented. This backfills active
maintainers based on recent contribution history.

Changes

Directory Added
/ (root) sanchezl, ardaguclu (reviewer + approver)
pkg/operator/ sanchezl, ardaguclu (reviewer + approver)
pkg/operator/apiserver/ sanchezl, ardaguclu (reviewer + approver)
pkg/operator/configobserver/apiserver/ sanchezl (reviewer + approver)
pkg/operator/staticpod/ sanchezl (reviewer + approver)
pkg/crypto/ sanchezl (reviewer + approver), ibihim (reviewer)
pkg/operator/certrotation/ sanchezl (reviewer + approver), ibihim (reviewer)
pkg/authentication/ sanchezl (reviewer + approver), ibihim (approver)
pkg/authorization/ sanchezl (reviewer + approver), ibihim (approver)
pkg/oauth/ ibihim (approver)
pkg/security/ sanchezl (reviewer + approver)

ibihim is already a reviewer in the auth directories; this promotes them to
approver there. ardaguclu is already an approver in the encryption
directories, so those are unchanged.

Cleanup of inactive owners (via emeritus_approvers) is intentionally left for
a separate PR.

/cc @ibihim @ardaguclu please ack being added as owners.

Summary by CodeRabbit

  • Chores
    • Updated project review and approval assignments across authentication, authorization, cryptography, OAuth, operator, configuration, static pod, and security areas.
    • Expanded the pool of designated reviewers and approvers to improve change review coverage.

Several directories list only owners who are no longer active, so Prow
suggests reviewers and approvers who do not respond. Add active
contributors based on recent contribution history:

- sanchezl: crypto, operator/certrotation, operator/apiserver,
  operator/configobserver/apiserver, operator/staticpod, authentication,
  authorization, security, and root plus pkg/operator
- ibihim: authentication, authorization, oauth (approver); crypto and
  operator/certrotation (reviewer)
- ardaguclu: root, pkg/operator, operator/apiserver

This is an additive change only; cleanup of inactive owners is left for a
separate PR.
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0c615ef2-7ddb-4bcb-b276-4aca51111d20

📥 Commits

Reviewing files that changed from the base of the PR and between a0584a6 and 7cc0939.

📒 Files selected for processing (11)
  • OWNERS
  • pkg/authentication/OWNERS
  • pkg/authorization/OWNERS
  • pkg/crypto/OWNERS
  • pkg/oauth/OWNERS
  • pkg/operator/OWNERS
  • pkg/operator/apiserver/OWNERS
  • pkg/operator/certrotation/OWNERS
  • pkg/operator/configobserver/apiserver/OWNERS
  • pkg/operator/staticpod/OWNERS
  • pkg/security/OWNERS

Walkthrough

The pull request updates the root and package-level OWNERS files with additional reviewers and approvers.

Changes

OWNERS updates

Layer / File(s) Summary
Repository ownership updates
OWNERS
Adds sanchezl and ardaguclu as reviewers and approvers.
Package ownership updates
pkg/authentication/OWNERS, pkg/authorization/OWNERS, pkg/crypto/OWNERS, pkg/oauth/OWNERS, pkg/operator/..., pkg/security/OWNERS
Adds reviewers and approvers across the listed package ownership files while retaining existing approvers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7cc09

This change adds active maintainers to repository ownership files without removing existing owners or changing product behavior. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding active maintainers to under-owned OWNERS files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff changes only OWNERS files by adding owner usernames; it introduces no Ginkgo tests or test-title constructs.
Test Structure And Quality ✅ Passed The pull request changes only 11 OWNERS files, adding reviewer and approver entries; it introduces no Ginkgo tests or cluster operations subject to this check.
Microshift Test Compatibility ✅ Passed The pull request changes only 11 OWNERS files and adds no Ginkgo tests or other test files, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only 11 OWNERS files with additive owner entries; it adds no Ginkgo e2e tests or multi-node test behavior.
Topology-Aware Scheduling Compatibility ✅ Passed The pull request changes only 11 OWNERS files, adding reviewer and approver names. It changes no manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only 11 OWNERS metadata files with additive YAML entries; it adds no Go code or process-level stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only 11 OWNERS files, adding 31 lines; no Ginkgo tests, test code, IPv4 assumptions, or external connectivity requirements were introduced.
No-Weak-Crypto ✅ Passed The diff changes only 11 OWNERS files; all 31 additions are reviewer or approver names, with no weak-crypto usage or custom crypto implementation introduced.
Container-Privileges ✅ Passed The commit changes only 11 OWNERS files; all 31 additions are reviewer or approver names, and no privilege-related setting appears in the added diff.
No-Sensitive-Data-In-Logs ✅ Passed The diff only adds usernames to OWNERS YAML files; it introduces no logging or output of passwords, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from dgrisonnet and ibihim August 15, 2026 01:42
@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sanchezl

Copy link
Copy Markdown
Contributor Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@sanchezl: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial

Copy link
Copy Markdown
Contributor

/assign @bertinatto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants