Skip to content

[release-5.0] OCPBUGS-111300: Derive console notification docs URL from cluster version - #1679

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-5.0from
openshift-cherrypick-robot:cherry-pick-1676-to-release-5.0
Open

[release-5.0] OCPBUGS-111300: Derive console notification docs URL from cluster version#1679
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-5.0from
openshift-cherrypick-robot:cherry-pick-1676-to-release-5.0

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #1676

/assign lucaconsalvi

Replace the hardcoded OCP 4.22 docs URL in console notifications with
a dynamic version derived from ClusterVersion.Status.History[0].Version,
falling back to "latest" when unavailable. Follows the MCO pattern.

The config client and ClusterVersion informer are created locally in
runPacemakerControllers to keep changes within pkg/tnf/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 79727525-e8d4-44dc-8df4-c9eb4f48394d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jaypoulz and mshitrit August 17, 2026 13:05
@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fonta-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-109743 has been cloned as Jira Issue OCPBUGS-111300. Will retitle bug to link to clone.
/retitle [release-5.0] OCPBUGS-111300: Derive console notification docs URL from cluster version

Details

In response to this:

This is an automated cherry-pick of #1676

/assign lucaconsalvi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-5.0] OCPBUGS-109743: Derive console notification docs URL from cluster version [release-5.0] OCPBUGS-111300: Derive console notification docs URL from cluster version Aug 17, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-111300, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1676

/assign lucaconsalvi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lucaconsalvi

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@lucaconsalvi: This pull request references Jira Issue OCPBUGS-111300, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-109743 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-109743 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lucaconsalvi

Copy link
Copy Markdown
Contributor

/retest

@dhensel-rh

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-upgrade
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-single-node
/test e2e-gcp-operator
/test e2e-gcp-operator-disruptive
/test e2e-metal-ipi-ovn-ipv6
/test e2e-operator

@lucaconsalvi

Copy link
Copy Markdown
Contributor

Verification

Tested on a 5.0 cluster built from nightly 5.0.0-0.nightly-2026-08-11-014409 with this PR applied (cluster-bot build).

Cluster version reported: 5.0.0-0-2026-08-18-143706-test-ci-ln-cj2gsrb-latest

Steps:

  1. Confirmed healthy 2-node TNF cluster (master-0, master-1)
  2. Put master-1 in maintenance: pcs node maintenance master-1
  3. Waited ~35s for notification controller to sync
  4. Checked the ConsoleNotification object:
oc get consolenotification pacemaker-cluster-degraded -o jsonpath='{.spec.link.href}'

Result:

https://docs.redhat.com/en/documentation/openshift_container_platform/5.0/html/installing_a_two_node_openshift_cluster/two-node-with-fencing#operating-a-degraded-tnf

The link correctly uses /5.0/ derived from the cluster version instead of the old hardcoded /4.22/.

/verified by @lucaconsalvi

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@lucaconsalvi: This PR has been marked as verified by @lucaconsalvi.

Details

In response to this:

Verification

Tested on a 5.0 cluster built from nightly 5.0.0-0.nightly-2026-08-11-014409 with this PR applied (cluster-bot build).

Cluster version reported: 5.0.0-0-2026-08-18-143706-test-ci-ln-cj2gsrb-latest

Steps:

  1. Confirmed healthy 2-node TNF cluster (master-0, master-1)
  2. Put master-1 in maintenance: pcs node maintenance master-1
  3. Waited ~35s for notification controller to sync
  4. Checked the ConsoleNotification object:
oc get consolenotification pacemaker-cluster-degraded -o jsonpath='{.spec.link.href}'

Result:

https://docs.redhat.com/en/documentation/openshift_container_platform/5.0/html/installing_a_two_node_openshift_cluster/two-node-with-fencing#operating-a-degraded-tnf

The link correctly uses /5.0/ derived from the cluster version instead of the old hardcoded /4.22/.

/verified by @lucaconsalvi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants