Skip to content

🐛 [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 - #609

Open
katekeiroz-dev wants to merge 2 commits into
openshift:release-4.21from
katekeiroz-dev:CVE-2026-34986-4.21
Open

🐛 [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4#609
katekeiroz-dev wants to merge 2 commits into
openshift:release-4.21from
katekeiroz-dev:CVE-2026-34986-4.21

Conversation

@katekeiroz-dev

Copy link
Copy Markdown

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-81976, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-81976 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 034cf71b-d039-46ca-85bf-ae81c04be3de

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from racheljpg and serngawy June 2, 2026 10:13
@katekeiroz-dev

Copy link
Copy Markdown
Author

/ok-to-test

@katekeiroz-dev

Copy link
Copy Markdown
Author

/retest

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 3, 2026
@katekeiroz-dev

Copy link
Copy Markdown
Author

/retest

@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

3 similar comments
@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

@damdo

damdo commented Jul 23, 2026

Copy link
Copy Markdown
Member

@katekeiroz hey, this needs rebase and is not of the necessary format. It should be in 2 commits (one UPSTREAM: UPSTREAMPRNUMBER: zzzz one UPSTREAM: : vendor

see: #606

@katekeiroz-dev katekeiroz-dev changed the title [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 🐛 [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 Jul 23, 2026
@katekeiroz-dev

Copy link
Copy Markdown
Author

@damdo Rebased onto latest release-4.21 and reformatted into 2 commits matching #606's convention:

  1. UPSTREAM: 5995: Bump github.com/go-jose/go-jose/v4 from 4.1.1 to 4.1.4 (go.mod/go.sum only)
  2. UPSTREAM: <drop>: vendor (vendor/ update, scoped to go-jose only)

Also fixed the PR title to include the required 🐛 prefix (was failing verify PR contents). Build (go build ./...) and go mod verify both pass locally.

/retest

@damdo

damdo commented Jul 29, 2026

Copy link
Copy Markdown
Member

@katekeiroz-dev this is failing checks, PTAL

@katekeiroz-dev katekeiroz-dev changed the title 🐛 [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 Jul 29, 2026
@katekeiroz-dev katekeiroz-dev changed the title [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 🐛 [release-4.21] OCPBUGS-81976: Bump go-jose/go-jose/v4@v4.1.4 Jul 29, 2026
@katekeiroz-dev

katekeiroz-dev commented Jul 29, 2026

Copy link
Copy Markdown
Author

/override lint

The lint check failure is pre-existing on release-4.21 and unrelated to this PR. The make lint-api target runs golangci-lint custom, which tries to git clone --branch v2.1.0 from github.com/golangci/golangci-lint and fails with exit code 128. The main branch has already moved to v2.12.2 in .custom-gcl.yaml, but release-4.21 is still pinned to v2.1.0 where the custom subcommand is broken.

@damdo

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown

@katekeiroz-dev: katekeiroz-dev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override lint

The lint check failure is pre-existing on release-4.21 and unrelated to this PR. The make lint-api target runs golangci-lint custom, which tries to git clone --branch v2.1.0 from github.com/golangci/golangci-lint and fails with exit code 128. The main branch has already moved to v2.12.2 in .custom-gcl.yaml, but release-4.21 is still pinned to v2.1.0 where the custom subcommand is broken.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/verified by ci

/label backport-risk-assessed

@damdo

damdo commented Aug 10, 2026

Copy link
Copy Markdown
Member

@katekeiroz-dev there are issues with go mod tidy

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 10, 2026
@damdo

damdo commented Aug 10, 2026

Copy link
Copy Markdown
Member

/unlgtm

until those are fixed

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@damdo: This PR has been marked as verified by ci.

Details

In response to this:

/approve
/lgtm

/verified by ci

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@damdo damdo removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
katekeiroz-dev and others added 2 commits August 12, 2026 11:21
Signed-off-by: Kate Barreiros <kbarreir@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Kate Barreiros <kbarreir@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Aug 12, 2026
@katekeiroz-dev

Copy link
Copy Markdown
Author

/test unit

@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

@katekeiroz-dev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 9bd852a link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants