Skip to content

Add PodCertificateRequest feature gate to TechPreview - #2982

Open
redhat-chai-bot wants to merge 1 commit into
openshift:masterfrom
redhat-chai-bot:enable-podcertificaterequest-techpreview
Open

Add PodCertificateRequest feature gate to TechPreview#2982
redhat-chai-bot wants to merge 1 commit into
openshift:masterfrom
redhat-chai-bot:enable-podcertificaterequest-techpreview

Conversation

@redhat-chai-bot

Copy link
Copy Markdown

Summary

Register the PodCertificateRequest feature gate and enable it under TechPreviewNoUpgrade and DevPreviewNoUpgrade feature sets.

Details

This adds the upstream Kubernetes PodCertificateRequest feature gate (KEP 4317) to OpenShift.

  • Feature gate: PodCertificateRequest
  • Product scope: Kubernetes
  • Enabled in: TechPreviewNoUpgrade, DevPreviewNoUpgrade
  • Jira component: kube-apiserver
  • Contact: ibihim

Changed files

  • features/features.go — feature gate definition
  • features.md — documentation table update
  • payload-manifests/featuregates/featureGate-*.yaml — generated manifest updates for all SelfManagedHA and Hypershift profiles

Companion PR: cluster-kube-apiserver-operator#2266 (runtime-config mapping)


AI-generated. Review for accuracy.

@dgoodwin requested in Slack thread

Register the upstream Kubernetes PodCertificateRequest feature gate
(KEP-4317) and enable it in TechPreviewNoUpgrade and DevPreviewNoUpgrade
FeatureSets. This feature provides native workload identity via
PodCertificateRequest API and podCertificate projected volumes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Hello @redhat-chai-bot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fef23a3d-e850-446e-987e-77d8c5ea50d6

📥 Commits

Reviewing files that changed from the base of the PR and between d4bb0b4 and 0ed3a20.

📒 Files selected for processing (10)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

📝 Walkthrough

Walkthrough

The change registers the PodCertificateRequest feature gate with Kubernetes ownership and preview metadata. The feature support matrix marks it enabled for DevPreviewNoUpgrade and TechPreviewNoUpgrade profiles. Hypershift and SelfManagedHA manifests enable the feature in preview profiles and disable it in Default and OKD profiles.

Merge Risk: ⚪ Minimal · up to 0ed3a

This PR adds the PodCertificateRequest feature gate to the documented preview feature sets and updates the corresponding generated manifests. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding the PodCertificateRequest feature gate to TechPreview.
Description check ✅ Passed The description directly explains the feature gate registration, enablement profiles, affected files, and companion runtime configuration change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR diff changes only feature metadata, documentation, and YAML manifests; it adds or changes no Ginkgo It, Describe, Context, When, or similar test title.
Test Structure And Quality ✅ Passed The PR changes only feature registration, documentation, and YAML manifests; it adds no Ginkgo tests, It blocks, resource setup, waits, or assertions to review.
Microshift Test Compatibility ✅ Passed The HEAD diff adds only feature-gate metadata and YAML manifests; it adds no Ginkgo tests or test references to MicroShift-unavailable APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR diff contains only feature-gate metadata, documentation, and YAML manifests; it adds no Ginkgo tests or topology assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The HEAD diff only registers PodCertificateRequest, updates documentation, and changes FeatureGate status lists; it adds no deployment, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff adds only feature metadata, manifests, and a pure top-level feature registration chain; no OTE binary, suite setup, or stdout write is introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only feature metadata, documentation, and YAML manifests; it adds no Ginkgo e2e tests or test connectivity, IPv4, or external-service assumptions.
No-Weak-Crypto ✅ Passed The parent diff adds only PodCertificateRequest registration, documentation, and feature-gate manifest entries; no introduced line uses MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto.
Container-Privileges ✅ Passed The commit adds only PodCertificateRequest metadata and FeatureGate name entries; all changed YAML objects are FeatureGate configs with no privileged, host namespace, SYS_ADMIN, root, or allowPrivi...
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds feature metadata, documentation, and manifest entries; the parent-to-HEAD diff introduces no logging calls or sensitive data in logs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2026
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgoodwin

Copy link
Copy Markdown
Contributor

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/cluster-kube-apiserver-operator#2266/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial openshift/cluster-kube-apiserver-operator#2266

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@dgoodwin: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: openshift/cluster-kube-apiserver-operator#2266/payload-job-with-prs: string: openshift/cluster-kube-apiserver-operator#2266/payload-job-with-prs doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants