Fix legacy webhook URI without httpcore5#975
Open
MdTanwer wants to merge 1 commit into
Open
Conversation
MdTanwer
requested review from
AWSHurneyt,
KashKondaka,
bowenlan-amzn,
cwperks,
eirsep,
engechas,
getsaurabh02,
lezzago,
manaswini1920,
nishtham-amazon,
rishabhmaurya,
riysaxen-amzn,
toepkerd and
vikhy-aws
as code owners
Replace URIBuilder with java.net.URI so ISM custom webhook error notifications do not require hc.core5 on the plugin classpath. Fixes opensearch-project/OpenSearch#21601 Signed-off-by: MdTanwer <tanw9004167@gmail.com>
MdTanwer
force-pushed
the
fix/ism-custom-webhook-uri-21601
branch
from
150e62f to
e415e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.apache.hc.core5.net.URIBuilderwithjava.net.URIinLegacyBaseMessageThis fixes a
NoClassDefFoundErrorwhen ISM publishescustom_webhookerror notifications. The index-management plugin bundles HttpClient 4, but
LegacyBaseMessagereferenced HttpClient 5'sURIBuilder, which crashedthe node via uncaught
Errorhandling.Fixes opensearch-project/OpenSearch#21601
Test plan
./gradlew test --tests "org.opensearch.commons.destination.message.LegacyCustomWebhookMessageTest"