Skip to content

add ui metadata in workflow object#458

Open
eirsep wants to merge 1 commit into
opensearch-project:mainfrom
eirsep:ui
Open

add ui metadata in workflow object#458
eirsep wants to merge 1 commit into
opensearch-project:mainfrom
eirsep:ui

Conversation

@eirsep

@eirsep eirsep commented Jun 21, 2023

Copy link
Copy Markdown
Member

add ui metadata in worklfow object similar to ui metadata object present in monitor. this is required for dashboards to store metadata information

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov

codecov Bot commented Jun 21, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.76%. Comparing base (5ef9b55) to head (4abfb76).
⚠️ Report is 151 commits behind head on main.

Files with missing lines Patch % Lines
.../org/opensearch/commons/alerting/model/Workflow.kt 90.00% 0 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (73.76%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #458      +/-   ##
============================================
- Coverage     73.78%   73.76%   -0.03%     
- Complexity      819      820       +1     
============================================
  Files           126      126              
  Lines          5341     5348       +7     
  Branches        675      676       +1     
============================================
+ Hits           3941     3945       +4     
- Misses         1103     1104       +1     
- Partials        297      299       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lezzago lezzago changed the title add ui metadata in worklfow object add ui metadata in workflow object Jun 21, 2023
@lezzago

lezzago commented Jun 21, 2023

Copy link
Copy Markdown
Member

There has been talks about going away from this logic since if someone creates the monitor/workflow through the api, it can never be converted to the visual mode even if the visual mode would support that configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants