Repository navigation
bug: index bcr_staging modules in the registry frontend - #9
Merged
asymingt merged 1 commit intoOct 30, 2026
Merged
Conversation
Modules under bcr_staging/modules in ros-central-registry are published into the same registry as modules/ (see the "Assemble site" workflow step), but the frontend index never included them: - The gazelle extension built the module_registry rule from the subdirs of <registry-root>/modules only, so bcr_staging modules were walked but never linked into the registry's deps. - The submodule was sparse-checked-out to `modules` alone, so bcr_staging/ was not even on disk when `bazel run //:bcr` ran in CI. Fix both: - Add a repeatable --extra-modules-dir flag to //language/bcr. The module_registry rule now merges module names from every extra dir (deduped; the primary modules/ copy wins on conflict). The bulk `git log` commit preload and overlay lookup use the real on-disk location instead of a hardcoded modules/ prefix. - Pass --extra-modules-dir=bcr_staging/modules in //:bcr and include bcr_staging/modules in the Makefile / .gitmodules sparse-checkout. Also add ModuleVersion.registry_path (the version's directory relative to the registry repo root, e.g. "bcr_staging/modules/imgui/1.0"), populated by the gazelle extension via a new module_version attr and moduleversioncompiler flag. The UI uses it for overlay/patch "view on GitHub" links and raw-file fetches, which previously assumed modules/<name>/<version> and would 404 for staging modules. Signed-off-by: Andrew Symington <simmers@google.com>
asymingt
force-pushed
the
asymingt/make-sure-bcr-staging-modules-are-indexed
branch
from
October 30, 2026 19:58
6dbbdd5 to
38191e8
Compare
asymingt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules under bcr_staging/modules in ros-central-registry are published into the same registry as modules/ (see the "Assemble site" workflow step), but the frontend index never included them:
modulesalone, so bcr_staging/ was not even on disk whenbazel run //:bcrran in CI.Fix both:
git logcommit preload and overlay lookup use the real on-disk location instead of a hardcoded modules/ prefix.Also add ModuleVersion.registry_path (the version's directory relative to the registry repo root, e.g. "bcr_staging/modules/imgui/1.0"), populated by the gazelle extension via a new module_version attr and moduleversioncompiler flag. The UI uses it for overlay/patch "view on GitHub" links and raw-file fetches, which previously assumed modules// and would 404 for staging modules.
Fixes: #8