ENTSO-E agent#15
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 703d7fad4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
To use Codex here, create an environment for this repo. |
There was a problem hiding this comment.
Pull request overview
Introduces a new ENTSO-E agent extension that polls the ENTSO-E Transparency Platform API for day-ahead price data, converts publication documents into predicted datapoints, and adds integration tests plus test harness support for running in an extension-only repo.
Changes:
- Added ENTSO-E agent model/link/protocol implementation and XML (JAXB) DTOs to fetch and transform pricing data into predicted datapoints.
- Added Spock-based integration tests covering datapoint generation, time cutoffs, multi-zone behavior, error/no-data handling, and zone validation.
- Adjusted Gradle test environment to set a minimal manager UI docroot when
:openremoteis not present (plus a placeholder HTML docroot).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
test-support/manager-app/index.html |
Adds a minimal docroot placeholder for manager container startup during tests. |
project.gradle |
Sets OR_APP_DOCROOT for test runs when the :openremote project is absent. |
entsoe/src/test/groovy/.../EntsoeProtocolTest.groovy |
New ENTSO-E protocol integration/validation tests with a mocked HTTP client filter. |
entsoe/src/main/resources/META-INF/services/org.openremote.model.AssetModelProvider |
Registers the ENTSO-E asset model provider for auto-scan. |
entsoe/src/main/java/.../PublicationMarketDocument.java |
JAXB mapping for ENTSO-E publication document XML used to build datapoints. |
entsoe/src/main/java/.../EntsoeProtocol.java |
Core polling protocol: builds API URLs, fetches XML, parses, and writes predicted datapoints. |
entsoe/src/main/java/.../EntsoeAgentModelProvider.java |
Enables auto-scan for the extension’s model types. |
entsoe/src/main/java/.../EntsoeAgentLink.java |
Defines the link metadata (zone/EIC) with validation. |
entsoe/src/main/java/.../EntsoeAgent.java |
Defines the agent asset with security token and optional base URL. |
entsoe/build.gradle |
New module build/publish configuration for the ENTSO-E extension. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…etching is only done once.
|
Do you know why the CI/CD workflow doesn't finish and times out after 6 hours @ebariaux? |
|
@wborn Looking into it, but I have "integration tests" and I see there's nothing in the pipeline that sets up the required backend to run the tests. |
…p the stack for tests to run
|
@wborn I disabled the test under GitHub for now as discussed in SU and pipeline ran correctly. |
|
Can the documentation (openremote/documentation#152) also be added to this repo instead similar like we do for the other extensions? |
|
@wborn Documentation added in extension repo |
No description provided.