Skip to content

ENTSO-E agent#15

Merged
wborn merged 15 commits into
mainfrom
feature/entsoe-agent
Mar 27, 2026
Merged

ENTSO-E agent#15
wborn merged 15 commits into
mainfrom
feature/entsoe-agent

Conversation

@ebariaux
Copy link
Copy Markdown
Contributor

No description provided.

@ebariaux ebariaux requested a review from a team March 18, 2026 10:49
@ebariaux ebariaux added the Feature Development of new feature label Mar 18, 2026
@ebariaux ebariaux linked an issue Mar 18, 2026 that may be closed by this pull request
2 tasks
@wborn
Copy link
Copy Markdown
Member

wborn commented Mar 19, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 703d7fad4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wborn
Copy link
Copy Markdown
Member

wborn commented Mar 20, 2026

Let's see how the @copilot findings compare to the @codex findings.

Copy link
Copy Markdown

Copilot AI commented Mar 20, 2026

@wborn I've opened a new pull request, #17, to work on those changes. Once the pull request is ready, I'll request review from you.

@chatgpt-codex-connector
Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

Copilot AI mentioned this pull request Mar 20, 2026
4 tasks
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new ENTSO-E agent extension that polls the ENTSO-E Transparency Platform API for day-ahead price data, converts publication documents into predicted datapoints, and adds integration tests plus test harness support for running in an extension-only repo.

Changes:

  • Added ENTSO-E agent model/link/protocol implementation and XML (JAXB) DTOs to fetch and transform pricing data into predicted datapoints.
  • Added Spock-based integration tests covering datapoint generation, time cutoffs, multi-zone behavior, error/no-data handling, and zone validation.
  • Adjusted Gradle test environment to set a minimal manager UI docroot when :openremote is not present (plus a placeholder HTML docroot).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test-support/manager-app/index.html Adds a minimal docroot placeholder for manager container startup during tests.
project.gradle Sets OR_APP_DOCROOT for test runs when the :openremote project is absent.
entsoe/src/test/groovy/.../EntsoeProtocolTest.groovy New ENTSO-E protocol integration/validation tests with a mocked HTTP client filter.
entsoe/src/main/resources/META-INF/services/org.openremote.model.AssetModelProvider Registers the ENTSO-E asset model provider for auto-scan.
entsoe/src/main/java/.../PublicationMarketDocument.java JAXB mapping for ENTSO-E publication document XML used to build datapoints.
entsoe/src/main/java/.../EntsoeProtocol.java Core polling protocol: builds API URLs, fetches XML, parses, and writes predicted datapoints.
entsoe/src/main/java/.../EntsoeAgentModelProvider.java Enables auto-scan for the extension’s model types.
entsoe/src/main/java/.../EntsoeAgentLink.java Defines the link metadata (zone/EIC) with validation.
entsoe/src/main/java/.../EntsoeAgent.java Defines the agent asset with security token and optional base URL.
entsoe/build.gradle New module build/publish configuration for the ENTSO-E extension.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ebariaux ebariaux requested a review from wborn March 23, 2026 13:57
@wborn
Copy link
Copy Markdown
Member

wborn commented Mar 23, 2026

Do you know why the CI/CD workflow doesn't finish and times out after 6 hours @ebariaux?

@ebariaux
Copy link
Copy Markdown
Contributor Author

@wborn Looking into it, but I have "integration tests" and I see there's nothing in the pipeline that sets up the required backend to run the tests.
I suppose code is waiting for keycloak to be available...

@ebariaux
Copy link
Copy Markdown
Contributor Author

@wborn I disabled the test under GitHub for now as discussed in SU and pipeline ran correctly.

@wborn
Copy link
Copy Markdown
Member

wborn commented Mar 27, 2026

Can the documentation (openremote/documentation#152) also be added to this repo instead similar like we do for the other extensions?

@ebariaux
Copy link
Copy Markdown
Contributor Author

@wborn Documentation added in extension repo

Copy link
Copy Markdown
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 0569627 into main Mar 27, 2026
1 check passed
@wborn wborn deleted the feature/entsoe-agent branch March 27, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Development of new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create new extension - ENTSOE agent

4 participants