🐛(models) fix allow xapi Extensions with empty string values#631
Open
piptouque wants to merge 2 commits into
Open
🐛(models) fix allow xapi Extensions with empty string values#631piptouque wants to merge 2 commits into
piptouque wants to merge 2 commits into
Conversation
added 2 commits
June 15, 2026 10:34
The 'extensions` dict is shared by contexts and results, among others.
When defined with a bare Dict[...] as a field in a pydantic class, Extensions inherit from the config which disallows empty strings in dict values. This, however, should be allowed according to spec: https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#requirements-18 (An LRS MUST NOT reject a Statement based on the values of the extensions map). We must override base the model_config for our extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When defined with a bare
Dict[...]as a field in a pydantic class, extensions inherit from the config which disallows empty strings in dict values.This should be allowed according to spec.
Proposal
We override the
model_configfor our extensions to allow for empty strings.ExtensionMapmodel_configforExtensionMapCHANGELOG.md