Repository navigation
refactor(tests): split mapping-test-cases.yaml by subcommand - #776
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe PR updates YAML CLI test cases for mapping evaluation, initialization, testing, and validation. The cases specify expected output and exit codes, including the deprecated ChangesMapping CLI tests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a test-only reorganization with no production behavior change, and no merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The refactor preserves all existing scenarios and the test runner discovers each new suite automatically.
0 open findings
What changed in this PR
Splits mapping integration tests by subcommand while preserving automatic Commander discovery.
Changes:
- Separates validate, test, init, and evaluate scenarios.
- Renumbers test cases within each suite without changing coverage.
| File | Description |
|---|---|
tests/mapping-validate-test-cases.yaml |
Contains validation tests. |
tests/mapping-test-test-cases.yaml |
Contains mapping test-runner tests. |
tests/mapping-init-test-cases.yaml |
Contains initialization tests. |
tests/mapping-evaluate-test-cases.yaml |
Retains evaluate and deprecated alias tests. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
760d1bc to
6a1811e
Compare
mapping-test-cases.yaml covered all four mapping subcommands in one file. Splits it into one file per subcommand so each is independently scannable and failures are immediately attributable. Commander discovers all YAML files in tests/ via --dir, so no runner changes are needed.
6a1811e to
91ce94e
Compare
Stacks on #775.
mapping-test-cases.yamlcovered all four mapping subcommands in one file. Splits it into one file per subcommand —mapping-validate-test-cases.yaml,mapping-test-test-cases.yaml,mapping-init-test-cases.yaml, andmapping-evaluate-test-cases.yaml— so each is independently scannable and test failures are immediately attributable to a subcommand.No runner changes needed. Commander discovers all YAML files in
tests/via--dir, so the new files are picked up automatically.Summary by CodeRabbit
evaluateas the primary command and verify that its deprecatedrunalias warns while still producing output.