feat(progress): allow customizing completion percentage precision - #2053
feat(progress): allow customizing completion percentage precision#2053Agrendalath wants to merge 1 commit into
Conversation
It can be adjusted with the `COMPLETION_PERCENTAGE_PRECISION` config.
|
Thanks for the pull request, @Agrendalath! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
+ Coverage 93.58% 93.60% +0.01%
==========================================
Files 367 367
Lines 6004 6007 +3
Branches 1416 1417 +1
==========================================
+ Hits 5619 5623 +4
+ Misses 368 367 -1
Partials 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The completion donut chart on the progress tab always rounds its percentages to whole numbers. In courses with a large number of units, a learner can complete several units in a row without the chart moving at all, which is confusing.
This PR adds a
COMPLETION_PERCENTAGE_PRECISIONenvironment variable that controls how many decimal places the chart's percentages are rounded to. It defaults to0, so it is fully backward -compatible.Testing instructions
COMPLETION_PERCENTAGE_PRECISIONin the MFE envs (e.g., via theMFE_CONFIG) and visit the course progress page.Deadline
"None"
Other information
Private-ref: BB-11198
TODO: The only missing thing is the product proposal.