feat: independent configuration of NOTIFY action config#13070
Open
Nil20 wants to merge 9 commits into
Open
Conversation
Contributor
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
Contributor
|
ℹ️ Coverage metrics explained: |
Contributor
📊 commons test coverage |
Contributor
📊 events test coverage |
Contributor
|
Your environment is deployed to https://ocrvs-12789.e2e-k8s.opencrvs.dev |
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ActionType.NOTIFYpreviously shared theActionType.DECLAREaction config — there was no way to configure label, flags, icon, or conditionals for NOTIFY independently.What this PR addresses (all acceptance criteria):
NotifyConfigadded to theActionConfigdiscriminated union. Supportslabel,flags,icon,conditionals,deduplication, and an optionalreviewfield.getActionConfig()returns the dedicated NOTIFY config when present; when absent, it falls back to the DECLARE config exactly as before. Backwards compatible by construction.resolveEventCustomFlagscallsgetActionConfigper action, so flag operations on NOTIFY no longer bleed into DECLARE and vice versa when a dedicated NOTIFY config is present.DeclareActionMenupicks up NOTIFY-specificsupportingCopyandiconfrom the NOTIFY config when present, falling back todialogCopy.notifyfrom the DECLARE config.ACTIONS.mdupdated: NOTIFY is now listed as independently configurable with the fallback behaviour documented.getActionConfigfallback/isolation tests added toutils.test.ts; flag isolation tests added toflags.test.ts.Notify.interaction.stories.tsxverifies that NOTIFY-specificsupportingCopyappears in the confirmation dialog and the notify (not declare) mutation is called.What is NOT addressed (explicitly out of scope per the issue):
Checklist