Repository navigation
fix(fs): register watch callbacks as change listeners - #180
Merged
steipete merged 2 commits intoOct 16, 2026
Merged
Conversation
Ports oven-sh#43765 by robobun and adds a portable Node 24 listener oracle.
steipete
marked this pull request as ready for review
October 16, 2026 11:29
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Registers the listener passed to
fs.watch()as achangelistener on the returnedFSWatcher. Listener inspection, manualemit(), removal, and registration order now include that callback. The separate callback field and its duplicate dispatch sites are removed. A rejected listener releases the native watch rather than leaving an open handle.Ports the existing open proposal oven-sh/bun#43765, by robobun. No competing upstream proposal is needed.
How did you verify your code works?
listenerCount("change").test/js/node/watchandtest/js/node/fsrun records 1,030 passes and 122 skips. Its four load errors came from omitting the internal-testing flag; rerunning only those four files with the standardBUN_FEATURE_FLAG_INTERNAL_FOR_TESTING=1 --expose-internalssetup gives 18 passes, 5 platform skips, and no failures on both baseline and patched builds.