Add new config "stopOnTyping" for subtitles#1672
Merged
gregorydlogan merged 1 commit intoopencast:developfrom Apr 15, 2026
Merged
Add new config "stopOnTyping" for subtitles#1672gregorydlogan merged 1 commit intoopencast:developfrom
gregorydlogan merged 1 commit intoopencast:developfrom
Conversation
|
This pull request is deployed at test.editor.opencast.org/1672/2026-04-14_08-35-43/ . |
| # Default: "captions" | ||
| #mainFlavor = "captions" | ||
|
|
||
| # If set to true, video playback stops when typing in the subtitle fields |
Member
There was a problem hiding this comment.
This needs a change in opencast/opencast right? I don't see a PR for it, unless I've missed it?
Member
Author
There was a problem hiding this comment.
Good catch, I keep forgetting that changes I make to the toml here do not automatically propagate to the toml in opencast/etc/ui-config/editor ^^'
|
This pull request has conflicts ☹ |
Adds a new option to have video playback in the subtitle editor pause automatically if the user starts typing in one of the subtitle boxes.
2139a2d to
ed59597
Compare
Arnei
added a commit
to Arnei/opencast
that referenced
this pull request
Apr 14, 2026
New config option from opencast/editor#1672. opencast/editor#1672 should be merged first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1397.
Adds a new option to have video playback in the subtitle editor pause automatically if the user starts typing in one of the subtitle boxes.