Repository navigation
fix(imports): honor bounded Retry-After on hosted scanner reads - #2086
mldangelo-oai wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for keeping retries bounded and preserving the original request scope. This owner-level merge-safety review found no material issues: only an eligible read is retried, cancellation stops the wait, and a persistent failure still prevents partial output.
Validation: 54 focused HTTP, collector and CLI tests passed, including all three HTTP-date formats, exact delay boundaries, cancellation, repeated throttling and late-page recovery. Types and formatting passed. Two unchanged persistence cases were filtered because of the established environment limitation; no live vendor tenant was contacted.
…d-scanner-backpressure
Summary
A short rate limit on a late page should not force an entire hosted scanner collection to restart.
Changes
Testing
The recorded suite counts below are historical results from before this rebase; they do not attest to the current head.
Current head
git diff --checkpassed. Fresh CI and automated review run on this updated head.Historical validation before rebase
56 focused tests passed across both collectors, the CLI and shared transport on the original tested tree. Covered missing, invalid, elapsed, excessive and repeated limits, cancellation, stable page query and credentials, and a recovered late page. No live Snyk or Semgrep tenant was contacted.
Risk and rollout
Depends on the hosted scanner collection parent PR; this PR targets
dev/codex/hosted-scanner-findings.Base branch:
dev/codex/hosted-scanner-findings(the hosted collection parent).Requires the hosted collection parent. At most one additional GET and ten seconds of waiting per eligible page; no new flags, storage, API keys, or fallback hosts.
Public disclosure review