Repository navigation
chore(deps): update ip-address in triage evals - #2034
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for updating the eval dependency and removing the obsolete override. No blocking findings in this owner-level merge-safety review of 47b5bc3. Both consumers accept and resolve 10.7.4; the lockfile changes only this package, and the seven-day cooldown has elapsed.
Frozen installation, benign IPv4/IPv6/zone handling through both consumers, runtime checks and all seven runner tests passed. Base/head production audits confirm that the ip-address advisory is the only removed finding; seven existing advisories remain, so audit still exits 1. I also inspected the passing deterministic-eval CI log for the merge of this exact head and base. Full eval contracts were verified in CI, not rerun locally.
Summary
Update
ip-addressfrom 10.7.2 to 10.7.4 in the triage evals. This fixes quadratic processing of malformed IPv6 zone identifiers. Upstream advisoryChanges
socksoverride. Bothsocksandexpress-rate-limitaccept 10.7.4 in their published dependency ranges.Testing
node --run test:deterministicpassed after the SDK build completed. Its final 16 runner and provider checks all passed. An earlier, overlapping rebuild removed a compiled SDK module during the first test run.pnpm audit --prod --jsonon the base and PR lockfiles. Both audited 759 dependencies. The advisory count fell from eight to seven, and theip-addressadvisory was the only difference. The audit still exits 1 for the remaining advisories.Risk and rollout
The change applies to the triage eval installation. npm published 10.7.4 on October 11, and the seven-day cooldown ended on October 18. The lockfile integrity matches the published tarball. npm release metadata
Public disclosure review