Changes to JOSS paper based on editor comments

[FlorianK13]

• [JOSS] Consider citing pvlib ANTS2D model #118

  • Done, added new citation

• [JOSS] Revise statement of need #119

  • Done

• [JOSS] pvlib should be noted as 2d #120

  • Done

• [JOSS] Does the shading mask correspond to cosine of angle of incidence? #121

  • I changed the formulation. Before I described the product of shading mask and cosine of angle of incident in one sentence which can be confusing. I now describe the shading mask as boolean (0 if sth shades the triangle, 1 otherwise) and multiply this with the cosine of angle of incidence. Mathematically this is still the same, but it is now easier to read and the shading mask can only be 0 or 1, which fits better to its name.

• [JOSS] How is GHI/DNI converted to radiances? #122

  • Done - reformulated Software Design - Input data chapter. This is now a tradeoff: The paper got even longer, but the topic is not trivial.

• [JOSS] Is there a citation for the Munich cite-scale demonstration study? #123

  • Done - see issue

  Moreover, I went through the paper and fixed some more typos and wrong wording, and I also shortended it a bit. The paper is still longer than the usual JOSS paper - if needed I can once more look for text that can be reduced.

[FlorianK13]

@MartGro can you take a look at the issue raised in #122 and at the new text i have added?

[FlorianK13]

@AdamRJensen thanks again for the issues you raised and the work you are doing for the journal. Can you take a look at the changes and see if your issues are addressed properly?

[AdamRJensen]

Thanks for the good work @FlorianK13

[FlorianK13]

@AdamRJensen thanks for your recent comments - i added a new commit to address them. If you agree with the current changes, I would merge the PR?