feat: Logging Hook by NeaguGeorgiana23 · Pull Request #139 · open-feature/cpp-sdk

NeaguGeorgiana23 · 2026-09-01T21:13:15Z

This PR

Logging Hook Support:
- Implements LoggingHook as mentioned in the OpenFeature specification.
- Introduces LogLevel and LogCallback for pluggable loggers with standard stream defaults.
- Supports all 4 hook stages (Before, After, Error, Finally) with optional evaluation context logging.
Exception Hierarchy:
- Adds structured OpenFeatureException hierarchy with associated ErrorCode values.
Serialization:
- Adds string conversions (ToString()) and streaming operators for EvaluationContext, Reason, ErrorCode, and Value.

Related Issues

Fixes #138

coderabbitai · 2026-09-01T21:13:22Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a423e475-4dd8-4c47-92eb-391dee1a9532

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

m-olko

I haven't finished the review, but I think I left enough comments. Please let me know when you fix them, I will continue with the review

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

…/cpp-sdk into global_hook_manager

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

…ature/cpp-sdk into hook_execution_lifecycle

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

…into logging_hook

## This PR Moves all linter fixes from PR #139 here. --------- Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

…ogging_hook

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

oxddr · 2026-10-02T11:29:00Z

+class OpenFeatureException : public std::runtime_error {
+ public:
+  explicit OpenFeatureException(ErrorCode error_code,
+                                const std::string& message = "")
+      : std::runtime_error(message.empty() ? std::string(ToString(error_code))
+                                           : message),
+        error_code_(error_code) {}
+
+  ErrorCode GetErrorCode() const noexcept { return error_code_; }
+
+ private:
+  ErrorCode error_code_{ErrorCode::kGeneral};
+};


I personally find creating an exception just for sake of grouping error-related information together confusing. Given we don't throw exceptions in the SDK, but we use absl::Status instead, I'd opt for creating struct of (absl:Status, error_message) instead.

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

NeaguGeorgiana23 requested review from a team as code owners September 1, 2026 21:13

NeaguGeorgiana23 requested review from m-olko and oxddr September 4, 2026 08:08

NeaguGeorgiana23 force-pushed the logging_hook branch from 826738a to 3d4f9a4 Compare September 15, 2026 13:33

NeaguGeorgiana23 changed the base branch from main to hook_execution_lifecycle September 15, 2026 13:37

NeaguGeorgiana23 added this pull request to stack #142 September 15, 2026 13:38

NeaguGeorgiana23 force-pushed the logging_hook branch from 3d4f9a4 to 7f804d3 Compare September 15, 2026 13:41

NeaguGeorgiana23 added 5 commits September 15, 2026 14:43

Create GlobalHookManager.

3720665

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

fix linter

79ce008

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

update FlagEvaluation flow

9edd9bc

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

fix linter.

85d7276

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Align provider hook collection during NOT_READY / FATAL states.

76a659e

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 force-pushed the logging_hook branch from 1598825 to 45e5c83 Compare September 15, 2026 14:44

m-olko reviewed Sep 15, 2026

View reviewed changes

Address comments.

79d91e1

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 mentioned this pull request Sep 18, 2026

chore: linter and build fixes #146

Merged

NeaguGeorgiana23 force-pushed the logging_hook branch from 8c89be8 to 860cd0e Compare September 21, 2026 08:09

NeaguGeorgiana23 added 6 commits September 21, 2026 10:20

Create GlobalHookManager.

312ec2f

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

fix linter

fdc9a10

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

update FlagEvaluation flow

d6925ab

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

fix linter.

f213f1f

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Align provider hook collection during NOT_READY / FATAL states.

5eb1571

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Address comments.

bdf2fb2

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 force-pushed the logging_hook branch from 860cd0e to 788658b Compare September 21, 2026 08:20

NeaguGeorgiana23 removed this pull request from stack #142 September 21, 2026 08:26

NeaguGeorgiana23 force-pushed the logging_hook branch from 788658b to 38bc034 Compare September 21, 2026 08:31

NeaguGeorgiana23 added 7 commits September 21, 2026 09:39

Merge branch 'global_hook_manager' of https://github.com/open-feature…

5046193

…/cpp-sdk into global_hook_manager

address comments

fa555b5

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Fix destroy static bug.

91e6813

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

update FlagEvaluation flow

2bb9dd1

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

fix linter.

2845c3a

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Align provider hook collection during NOT_READY / FATAL states.

5c898e8

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Address comments.

efd5a7f

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 force-pushed the logging_hook branch from 38bc034 to e2c2cad Compare September 21, 2026 13:45

NeaguGeorgiana23 added 4 commits September 21, 2026 13:50

Merge branch 'hook_execution_lifecycle' of https://github.com/open-fe…

22ad499

…ature/cpp-sdk into hook_execution_lifecycle

chore: fix clang-tidy warnings and .Build() naming

f845ee1

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

delete unused value.

7f4da0b

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

feat: implement LoggingHook

244b69d

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 force-pushed the logging_hook branch from e2c2cad to 244b69d Compare September 21, 2026 13:57

Merge branch 'logging_hook' of https://github.com/open-feature/cpp-sdk …

18a04e3

…into logging_hook

Base automatically changed from chore/linter-and-build-fixes to main September 22, 2026 17:59

NeaguGeorgiana23 added a commit that referenced this pull request Sep 22, 2026

chore: linter and build fixes (#146)

acc424b

## This PR Moves all linter fixes from PR #139 here. --------- Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

NeaguGeorgiana23 added 2 commits September 22, 2026 19:40

Merge branch 'main' of https://github.com/open-feature/cpp-sdk into l…

49e2324

…ogging_hook

Merge branch 'main' of https://github.com/open-feature/cpp-sdk into l…

b6d65c7

…ogging_hook

NeaguGeorgiana23 requested a review from m-olko September 30, 2026 10:54

m-olko reviewed Sep 30, 2026

View reviewed changes

NeaguGeorgiana23 added 2 commits October 1, 2026 17:45

address second round of reviews.

a316529

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

fix clang

45f66f5

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

oxddr reviewed Oct 2, 2026

View reviewed changes

NeaguGeorgiana23 added 2 commits October 5, 2026 14:25

Fix tests as suggeste in comments.

3bf079f

Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>

Merge remote-tracking branch 'origin/main' into logging_hook

d20a2b0

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

NeaguGeorgiana23 requested a review from oxddr October 5, 2026 19:09

Conversation

NeaguGeorgiana23 commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR

Related Issues

Uh oh!

coderabbitai Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m-olko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oxddr Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NeaguGeorgiana23 commented Sep 1, 2026 •

edited

Loading

coderabbitai Bot commented Sep 1, 2026 •

edited

Loading