chore: CI build-example-matrix: replace lerna with node script#166
Open
X-Guardian wants to merge 2 commits intoopen-constructs:mainfrom
Open
chore: CI build-example-matrix: replace lerna with node script#166X-Guardian wants to merge 2 commits intoopen-constructs:mainfrom
X-Guardian wants to merge 2 commits intoopen-constructs:mainfrom
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why
The
build-example-matrixCI job currently runsnpx lerna listto obtain a list of example projects to run the example integration tests on. Because a prioryarn installhas not been run,npxdoesn't use thelernaversion pinned in this repo'spackage.jsonbut resolves and downloads its own copy of the latest matching version every CI run. That means:npxhappens to fetch, not the version we've tested against.We could add a
yarn installstep, but this would add more runtime to the CI when it is not required.Changes
npx lerna list … | jq …shell pipeline in .github/workflows/examples.yml with a singlenode tools/build-example-matrix.mjsinvocation piped throughtee -a $GITHUB_OUTPUT.tools/build-example-matrix.mjsthat walksexamples/, reads eachpackage.json, filters out private workspaces and emits the matrix as JSON.The new script has no dependencies and produces the same output.
Checklist