feat(cli): support cdktn.json config file#153
Open
gabegorelick wants to merge 1 commit intoopen-constructs:mainfrom
Open
feat(cli): support cdktn.json config file#153gabegorelick wants to merge 1 commit intoopen-constructs:mainfrom
gabegorelick wants to merge 1 commit intoopen-constructs:mainfrom
Conversation
Support cdktn.json in addition to cdktf.json. When both are present, cdktn.json will be used. See open-constructs#152
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support cdktn.json in addition to cdktf.json. When both are present, cdktn.json will be used.
See #152
Related issue
Fixes #152
Description
Extra config file resolution into shared utilities. Those utilities check for
cdktn.jsonand fallback tocdktf.jsonifcdktn.jsondoes not exist.cdktf.jsonis still referenced in many of the examples and docs, and it is still emitted bycdktn init. Followup work can update those instances.Checklist