Skip to content

docs: 📝 add logos to bottom of landing page#144

Open
lwjohnst86 wants to merge 6 commits into
mainfrom
docs/add-logos-to-bottom-of-landing-page
Open

docs: 📝 add logos to bottom of landing page#144
lwjohnst86 wants to merge 6 commits into
mainfrom
docs/add-logos-to-bottom-of-landing-page

Conversation

@lwjohnst86

Copy link
Copy Markdown
Member

Description

Closes #133

Needs a quick review.

Checklist

  • Ran just run-all

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner July 1, 2026 12:13
@lwjohnst86 lwjohnst86 moved this from Todo to In review in Data development Jul 1, 2026

@signekb signekb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The height doesn't seem to do what we want here, resulting of logos with quite different sizes.

Wide/normal screen:

Image

Narrow screen:

Image

You could add the logos to the footer here instead as on the main website?

https://github.com/onlimit-study/main-website/blob/be549bbc505b3478faad5046c836be5348ecab75/_quarto.yml#L29

@github-project-automation github-project-automation Bot moved this from In review to In progress in Data development Jul 2, 2026
@lwjohnst86

Copy link
Copy Markdown
Member Author

I can't seem to be able to put footers on individual pages (which makes sense). And yea, I don't love the sizing issue, but I think that's because of the original images themselves being different sized. I don't know an easy fix for that without spending too much time on it.

@lwjohnst86

Copy link
Copy Markdown
Member Author

@signekb ah, I can switch to width, not height ☺️

@lwjohnst86 lwjohnst86 moved this from In progress to In review in Data development Jul 2, 2026
@lwjohnst86 lwjohnst86 requested a review from signekb July 2, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Include logos in footer

2 participants