Skip to content

docs: 📝 explain how to use core.py files#138

Open
lwjohnst86 wants to merge 4 commits into
mainfrom
docs/explain-about-core-py-file
Open

docs: 📝 explain how to use core.py files#138
lwjohnst86 wants to merge 4 commits into
mainfrom
docs/explain-about-core-py-file

Conversation

@lwjohnst86

Copy link
Copy Markdown
Member

Description

This adds to the layout description of the src/ Python files.

Needs a quick review.

Checklist

  • Ran just run-all

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner July 1, 2026 11:40
@lwjohnst86 lwjohnst86 moved this from Todo to In review in Data development Jul 1, 2026

@martonvago martonvago left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some questions ☺️

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
@github-project-automation github-project-automation Bot moved this from In review to In progress in Data development Jul 1, 2026
lwjohnst86 and others added 2 commits July 2, 2026 10:18
Co-authored-by: martonvago <57952344+martonvago@users.noreply.github.com>
@lwjohnst86 lwjohnst86 moved this from In progress to In review in Data development Jul 2, 2026
@lwjohnst86 lwjohnst86 requested a review from martonvago July 2, 2026 08:33
@lwjohnst86

Copy link
Copy Markdown
Member Author

@martonvago I added more content to address your questions ☺️

Comment thread CONTRIBUTING.md Outdated
@github-project-automation github-project-automation Bot moved this from In review to In progress in Data development Jul 2, 2026
@lwjohnst86 lwjohnst86 requested a review from martonvago July 2, 2026 12:39
@lwjohnst86 lwjohnst86 moved this from In progress to In review in Data development Jul 2, 2026
Comment thread CONTRIBUTING.md
folder name. For example, `metadata/core.py` contains functions for top-level
metadata processing that is for general metadata, but not strictly tied to any
given source or resource, such as data package-level metadata. Meanwhile,
`data/redcap/vas/core.py` contains functions for processing REDCap data that

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I understand, what's the difference between data/redcap/vas.py (logic for processing VAS data) and data/redcap/vas/core.py (general VAS data processing logic)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dammit, another mistake 🤦 🤪 I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants