[fix][test] Split and fix flaky SASL authentication first-stage auth cache tests#49
Open
oneby-wang wants to merge 3 commits into
Open
[fix][test] Split and fix flaky SASL authentication first-stage auth cache tests#49oneby-wang wants to merge 3 commits into
oneby-wang wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache#24337
Motivation
SaslAuthenticateTest.testSaslOnlyAuthFirstStagecurrently verifies two timing-sensitive behaviors in one test: that first-stage SASL authentication leaves inflight contexts in the cache, and that residual contexts are later expired. The exact cache-size assertion can become flaky when entries expire before the assertion is reached.Modifications
Added two focused tests for the separate behaviors:
testSaslOnlyAuthFirstStageKeepsInflightContextsBeforeExpiryverifies that first-stage SASL authentication keeps inflight contexts when the expiry timeout is long enough.testSaslOnlyAuthFirstStageExpiresResidualContextsverifies that residual first-stage contexts expire and are removed after cleanup.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes