Repository navigation
Fix CI: sync lockfile and modernize Node.js matrix - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI has been red on
mastersince "Update NPM config file formats" (5175b6b): the regeneratedpackage-lock.json(lockfileVersion 3) was out of sync withpackage.json(csstypepeer ofgoober), sonpm cifailed in the Compressed Size job. Meanwhile the test matrix still ran Node 12/14, whose npm 6 can't read a v3 lockfile — it installed a drifted prettier and failed lint on untouched files.What changed
package-lock.jsonre-synced withnpm install: top-levelcsstypeis now2.6.21(thegooberpeer dep) with a nested3.2.3for@types/react.npm installreplaced withnpm ci, npm cache enabled.size-limitupgraded4.10.1→11.2.0(v11 is the latest major that still supports Node 18): v4 bundled with webpack 4, which crashes on Node 17+ (OpenSSL 3 removed the hash algorithms it uses); v11 uses esbuild.actions/checkoutandactions/setup-nodebumped to v4,codecov-actionto v4 (the old v1 targets a Node runtime GitHub no longer ships).size-limitbudgets adjusted to the new tool's measurements (a few entries ±10–40 B, e.g.HexColorPicker3.12 → 3.15 KB). No library code changed in this PR.Note
The size metric changed from gzip to brotli — modern size-limit's default. The numbers are nearly identical to the old webpack-4-gzip ones (that's why the budgets barely moved), but they aren't the same thing: size-limit now bundles with esbuild, whose output gzips ~400 B worse and brotlies back to the old figures.
How to review
package-lock.jsonis 99% mechanical (size-limit dependency swap); the hand-made changes arenode.yml, thedevDependencies/size-limitsections ofpackage.json. Lint, tests andnpm run sizeall pass locally on Node 22 withnpm ci-installed dependencies — exactly what the new workflow runs. Not verified: tokenless codecov upload on v4 (it doesn't fail the build either way), and the Compressed Size job on this PR will stay red until merge — it builds the base branch (master), whose lockfile is still broken; it self-heals for all future PRs once this lands.