Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing a persistent VM disk during an upgrade currently changes its bridged MAC because the launcher ties the address to the disk file's device, inode, and creation time. Existing DHCP reservations then stop matching even though the user is upgrading the same VM.
This change stores a versioned identity with a stable MAC alongside the VM's data. Existing MAC records migrate without changing the address, including when the disk has already been replaced. App updates, disk replacement, resizing, resets, and moves of the complete VM data folder retain the address. Damaged or unsupported records fail visibly instead of silently generating another address.
The bridged Networking sheet displays the MAC and provides Copy MAC and Generate new MAC…. Regeneration shows the proposed address and explains the DHCP-reservation impact before confirmation. It is disabled while the VM is open, and the final write checks the launcher's workspace lock plus the expected current MAC to reject concurrent launches or stale dialogs. Migration and regeneration retain the previous record for recovery.
A newly created workspace receives a fresh identity; copying the complete data folder deliberately preserves its identity. The documentation tells users to generate a new MAC before running such a copy as a separate VM. This PR does not introduce an import/duplicate workflow or change NAT and ephemeral-VM address behavior.
Validation:
make teston macOS with the Xcode toolchain, including Swift, guest, networking, launcher, storage, and build/cache tests.