Skip to content

Drop macbook12-spi-driver-dkms, which no longer builds on 7.x kernels - #12007

Open
karlentwistle wants to merge 1 commit into
omacom:quattrofrom
karlentwistle:drop-macbook12-spi-driver
Open

karlentwistle wants to merge 1 commit into
omacom:quattrofrom
karlentwistle:drop-macbook12-spi-driver

Conversation

@karlentwistle

Copy link
Copy Markdown

install/hardware/apple/fix-spi-keyboard.sh installs macbook12-spi-driver-dkms on SPI-keyboard MacBooks, but the package no longer builds against 7.x kernels (linux-omarchy is 7.2.3). On 7.2.3 the DKMS build fails whenever headers are installed or the kernel updates:

apple-ib-als.c:679:19: error: initialization of 'void (*)(struct platform_device *)' from incompatible pointer type 'int (*)(struct platform_device *)'
apple-ibridge.c:901:10: error: 'struct acpi_driver' has no member named 'owner'
==> WARNING: `dkms install --no-depmod macbook12-spi-driver/0+git.315 -k 7.2.3-arch1-3' exited 10

The keyboard and trackpad don't depend on it: applespi has been in mainline since 5.3, and it's what gets loaded (/lib/modules/7.2.3-arch1-3/kernel/drivers/input/keyboard/applespi.ko.zst). The mkinitcpio MODULES drop-in only names in-tree modules, so it stays as it is.

Changes:

  • Stop installing the package in fix-spi-keyboard.sh
  • Remove it from omarchy-other.packages
  • Add a migration that drops it from existing installs

Tested on a MacBook9,1 (Omarchy 4.0.3, kernel 7.2.3-arch1-3): removed the package, the UKI rebuilt cleanly, and after a reboot the keyboard works at the LUKS prompt and in the session. The migration no-ops when the package is absent. ./test/cli and test/shell.d/t2-hardware-test.sh (which reads omarchy-other.packages) pass.

One note for the 2016–17 Touch Bar MacBook Pros (MacBookPro13,2/13,3/14,2/14,3): the Touch Bar and ambient light sensor drivers came from this package. They already fail to build, so removing it doesn't take anything away that currently works, but I haven't been able to test on those models.

🤖 Generated with Claude Code

applespi is in mainline and drives the keyboard and trackpad on SPI
MacBooks. The out-of-tree package fails its DKMS build on 7.x kernels,
so every kernel update prints an error for it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@neheb

neheb commented Sep 15, 2026

Copy link
Copy Markdown

Sounds like it should be forked, fixed, and the upstreamed stuff removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants