Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While the lock view is active, the background
MouseAreawakes the display on any pointer position change (onPositionChanged: root.wakeRequested()), not just on deliberate input. That means:Wake should happen only on deliberate interaction: a mouse click or any keyboard input. Those wake paths are unchanged (
onClicked, password fieldonTextChanged,Keys.onPressed), and because they still go throughrunWake()/armBlankTimer()the existing 5 s re-blank semantics are preserved.Change
Remove the single
onPositionChanged: root.wakeRequested()handler from the lock view's backgroundMouseArea. Click and key wake are untouched.Behavior
Before: moving the pointer over the locked, blanked display turns it back on.
After: a click or any key lights it to the password prompt; pointer motion alone keeps it dark.
Testing
./test/shellpasses; the lock-area tests (video-background-test.sh,lock-fingerprint-indicator,lock-password-overflowfixtures) pass. Five unrelated files fail on this machine for environmental reasons (config-test, locate-test, omarchy-kernel-migration-test, snapper-test, unowned-system-paths-test) — none reference the lock plugin. Verified live on Omarchy 4.0.3-1: with the handler removed, locked-screen mouse motion no longer wakes it while clicks and keypresses still do.