Repository navigation
Implement the t15-t17 design handoff punch list - #44
Merged
Merged
Conversation
① 17a — en.daysLeft "Days remaining" → "Days left" (zh unchanged); widen .cw-exp expiry column 80→96px (both densities; .cw-exp-s left at 70px). Sync the one en assertion in test/i18n.test.mjs. ② 17b — wide Benefits per-card chips always carry an amount: unused = gray "⋯tail $0", partial = green "⋯tail $x" (unchanged), fully used = green "⋯tail ✓ $y" (y = that card's full allotment). Added-tab chips stay amount-free (separate vocabulary). Inactive-benefit chips left as-is (pre-activation has no usage/limit semantics). ③ 17c — confirm throttle threshold tasks.length 30 → 80; demote the amber .cf-warn banner to a plain grey .cf-note (var(--text-3), no background/border/icon); rewrite confirmThrottle copy (zh/en) to point at the real fuse (auto-stop on rate limit, retry later). No footer warning; 429/403 circuit-breaker untouched. ④ 16a — .cw-exp gets align-self: flex-start so the expiry text top- aligns when +N chip expansion grows the row (merchant/status columns stay centered per the mock). ⑤ 16d — grayscale convergence: every information-bearing small-text selector moves to #6A6F7A (var(--text-3)); #8A8F99/#9CA1AB kept only on input placeholders and decorative glyphs (⌕, ▾▴ carets, +N affordance) and the tertiary confirm recap line. 34 selectors recolored; --mut alias now unused. ⑥ 12a — .wbtile .n gets min-width: 5.5ch + text-align: right so the wide stat tiles do not reflow when single-card filtering shrinks the number. Network/execution layer untouched; execution-copy forbidden words absent; no over-claim of one-shot concurrency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The six items from the design round's handover note (
design/v2/交接说明-t15-17.html, mocks 16a/16d/17a/17b/17c):en.daysLeft→Days left: {n}(30% shorter, still plural-safe); expiry column 80→96px both languages.$0unused / green$xpartial / green✓ $yfully used — so the gray chip no longer collides with the added-tab gray chip (= no cashback posted). Added-tab and inactive-benefit chips untouched..cw-exptop-aligns (align-self: flex-start) so the expiry cell no longer drifts when +N expands a chips row.#6A6F7A;#8A8F99/#9CA1ABretained only for placeholders and decorative glyphs (8 kept, each justified;.cf-metastays tertiary per the more-specific 17c mock).min-width: 5.5ch+ right-align to stop filter-switch jitter.MESSAGES: 2 value changes (daysLeft en, confirmThrottle zh/en). Only test change is the allowed daysLeft EN assertion.
Verification
lint / node --check / 77/77 tests / diff --check green, re-run independently by the supervisor; zero network/execution-layer changes; no forbidden execution wording. Browser harness check: Benefits wide chips show
$0/✓ $y, new stat labels and darker informational grays render as designed.Follow-up in this round: wide throttled-stop explainer strip (15b gap found in review) lands separately.
🤖 Generated with Claude Code