Move webpack-encore-bundle to require-dev and drop stale conflicts - #22
Merged
Merged
Conversation
The plugin ships no assets and no template calls encore_entry_*, so it was never a runtime dependency — but the Behat test app registers the bundle in bundles.php, so it stays in require-dev. Also drops the conflicts on symfony/framework-bundle 6.2.8 and api-platform/core 2.7.17, both inherited from the skeleton in bc4f278 and no longer reachable.
damic88
force-pushed
the
fix/encore-bundle-require-dev
branch
from
September 2, 2026 18:24
5acf803 to
2130b22
Compare
The manifest claimed PHP 8.0 support that cannot be installed: the Twig version reachable through sylius/mailer-bundle requires 8.1 or newer, so a fresh install on 8.0 fails during resolution with no indication that this package is the constraint. The CI matrix already covers 8.1 and 8.2 only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #21 The runtime requirement on
symfony/webpack-encore-bundleblocks projects that build their frontend with Vite.
The plugin has no
assets/, ships no compiled JS/CSS, and none of its Twigtemplates call
encore_entry_*. The requirement came in with bc4f278,copied from the Sylius plugin skeleton.
Kept in
require-devrather than removed:tests/Application/config/bundles.php:58registers
WebpackEncoreBundleand CI compiles the shop/admin entrypointswith it, so the test kernel needs the package.
Also drops the
conflictentries onsymfony/framework-bundle: 6.2.8andapi-platform/core: 2.7.17(single broken releases from the 1.12 era).behat/mink-selenium2-driverstays — that one is real.Note for the reporter: the real Vite risk is jQuery, not Encore —
Shop/Product/Show/_affiliate_referral.html.twiguses$.ajaxinline.Separate PR.