Repository navigation
prometheus: modular exporter module - #466
Draft
kafu-densha wants to merge 1 commit into
Draft
kafu-densha wants to merge 1 commit into
kafu-densha wants to merge 1 commit into
Conversation
Contributor
Author
|
making this more modular so we can add more exporters in the future, like the one I'm writing for printhost |
kafu-densha
force-pushed
the
modular-prom-exporter
branch
from
October 8, 2026 23:00
f3d61b9 to
bb00edb
Compare
dotlambda
reviewed
Oct 9, 2026
| exporters = lib.mkOption { | ||
| default = { }; | ||
| type = lib.types.attrsOf lib.types.submodule { | ||
| enable = lib.mkEnableOption "running this exporter"; |
Member
There was a problem hiding this comment.
Suggested change
| enable = lib.mkEnableOption "running this exporter"; |
| lib.mapAttrsToList ( | ||
| name: exporter: | ||
| let | ||
| serviceName = "prometheus-textfile-exporter-${name}"; |
Member
There was a problem hiding this comment.
Suggested change
| serviceName = "prometheus-textfile-exporter-${name}"; | |
| serviceName = "prometheus-textfile-exporter-${utils.escapeSystemdPath name}"; |
Comment on lines
+30
to
+32
| serviceName = lib.mkOption { | ||
| type = lib.types.str; | ||
| }; |
Member
There was a problem hiding this comment.
Suggested change
| serviceName = lib.mkOption { | |
| type = lib.types.str; | |
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.