[firecrawl-ui] Fix Extract: poll the async job for its result#90
Merged
Conversation
The v2 POST /extract response only carries { success, id } with no status
field, so the previous polling guard (status === 'processing') returned the
job stub immediately and the view reported a generic 'Extraction failed'.
Poll GET /extract/{id} whenever a job id is present and no inline data was
returned, stopping on a terminal status (completed, failed, cancelled) or
after a bounded number of attempts so a stuck job cannot hang the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract reported a generic "Extraction failed" on Firecrawl v2 instances. The cause is in the API adapter:
POST /v2/extractanswers asynchronously with just{ success: true, id }and nostatusfield, but the old polling guard only kept polling whenstatus === 'processing'. With no status on the initial response, it returned the job stub immediately, the view saw nodata, and surfaced the failure.The fix makes
waitForExtractpollGET /v2/extract/{id}whenever a job id is present and no inline data came back, stopping on a terminal status (completed,failed,cancelled) or after a bounded number of attempts so a stuck job cannot hang the UI. The endpoint stays/v2/extracton purpose: migrating to/v2/scrapewith a json format would drop multi-URL and prompt-only extraction.Test plan
npm cithennpm run buildsucceedsnpx prettier --check .andnpx eslint .pass