Drop nvisy-engine's Error type, rename CI workflows#326
Merged
Conversation
Our Error/ErrorKind/Result carried write-only capabilities: the
retryable flag, component tag, kind field, and 8 of 10 per-kind
shorthands were never read anywhere. Nothing outside the crate
matches on our ErrorKind. Every internal module except
pipeline/{mod,report}.rs already used elide_core::Error directly.
- Delete crates/nvisy-engine/src/error.rs (~230 lines).
- Rewrite the 5 remaining sites in pipeline/{mod,report}.rs to use
elide_core::Error::new(kind, msg) directly, with the message
composed inline where an underlying source was previously
chained via with_source.
- Re-export elide's Error/ErrorKind/Result at the crate root so
callers stay decoupled from elide-* crates. Also re-export
Scope, Entity, and the LLM provider variants that leak through
public struct fields on AnalyzedDocument, EntityRecord, and
LlmSource.
- Shorten PatternGuardrails' rustdoc summary so it fits on one
rendered line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
martsokha
added
refactor
- Rename workflow files: rs-{build,release,security}.yml →
runtime-*.yml, py-{build,release,security}.yml → inference-*.yml.
- Update workflow display names: "Rs Build" → "Runtime Build" etc.
- Update path filters inside each workflow to match the new names.
- Fix badge URLs in every crate/package README that pointed at the
old filenames.
- Update the dependabot-regen.yml comment referencing "Py Build".
Makefile Python targets (py-lint, py-test, etc.) are unchanged —
those name the tooling (ruff, pytest), not the CI pipeline.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
martsokha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two grouped cleanups:
Error type consolidation. Delete
nvisy_engine::{Error, ErrorKind, ErrorSource, Result}. The type carried write-only capabilities (retryable,component, kind field, 8 of 10 per-kind shorthands never read), and nothing outside the crate matches on ourErrorKind. Most internal modules already usedelide_core::Errordirectly — this drops the last 5 exceptions inpipeline/{mod,report}.rs. Net −310 lines. Re-exportError,ErrorKind,Result,Scope,Entity, andAuthenticatedProvider/UnauthenticatedProviderat the appropriate module roots so callers embedding this crate don't have to depend onelide-*directly to use its public API. Shortens `PatternGuardrails` rustdoc summary so it fits on one rendered line.CI workflow rename. Rename `rs-{build,release,security}.yml` → `runtime-.yml` and `py-{build,release,security}.yml` → `inference-.yml`. Update workflow display names, path filters, dependabot-regen comment, and badge URLs in every crate/package README. Makefile Python targets (`py-lint`, `py-test`, etc.) are unchanged — those name the tooling, not the CI pipeline.
Test plan
🤖 Generated with Claude Code