feat(patch): support npm: registry aliases in npm patch - #10007
Open
manzoorwanijk wants to merge 3 commits into
Open
manzoorwanijk wants to merge 3 commits into
manzoorwanijk wants to merge 3 commits into
Conversation
manzoorwanijk
marked this pull request as ready for review
September 21, 2026 07:48
Contributor
Author
|
CC: @reggi @martinrrm |
manzoorwanijk
force-pushed
the
feat/patch-add-npm-alias
branch
from
October 5, 2026 07:12
6cb729a to
d7b9740
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm patch add <alias>for annpm:registry alias looked the alias name up as a real package, so it fetched the wrong tarball or failed. This PR makesadd,commitandupdatefetch the alias target's tarball while keying the selector and patch file on the alias name, which is what the install engine matches.addaccepts the alias name (my-lodash) or the full spec (my-lodash@npm:lodash@4.17.21) and resolves the real package from the installed nodes or the declarednpm:spec (patch.js)..npm-patch-alias.jsonmarker socommitwritesmy-lodash@<version>. The marker is left out of the diff and checked against the edited package.updaterebases the real package's tarballs and keeps the marker through a conflicted rebase.EPATCHAMBIGUOUS, and an explicit alias that disagrees with the installed package fails withEPATCHALIAS.npm patch add lodashsuggests the alias name when lodash is installed only through an alias.References
Follow-up to #9439