Repository navigation
Make installHostKeyRouting the single entry for host focus handling - #176
Merged
satoshi-szk merged 1 commit intoOct 16, 2026
Conversation
After installHostKeyRouting was added, a GUI could get the focus restorer either from createHostFocusRestorer or from the routing, and the routing options were still named after the restorer. Two entry points invite GUIs that restore focus without installing the routing. createHostFocusRestorer and HostFocusRestorer are now internal, the options are HostKeyRoutingOptions, and wrac-gain uses the restorer returned by installHostKeyRouting. defaultIsEditableElement and EditableElementPredicate stay public so a GUI can extend the editable predicate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #175. After
installHostKeyRoutingwas added, the focus restorer could be obtained in two ways (createHostFocusRestorerand the routing'srestoreHostFocus), and the routing options were still namedHostFocusRestorerOptions. Two entry points make it easy to restore focus without installing the routing.Public API after this change:
installHostKeyRouting(runtime, options?)returns{ restoreHostFocus, dispose }HostKeyRouting,HostKeyRoutingOptionsdefaultIsEditableElement,EditableElementPredicate: kept so that a GUI can extend the editable predicateRemoved from the public API:
createHostFocusRestorer,HostFocusRestorer,HostFocusRestorerOptions. They remain internal building blocks.wrac-gainnow installs the routing and uses the returned restorer.Tests
wrac-frontend-runtime:npm test,npm run buildwrac-gain:vite build🤖 Generated with Claude Code