Skip to content

Raise the default macOS deployment target to 12.0 - #158

Merged
satoshi-szk merged 1 commit into
novonotes:novonotes-internalfrom
satoshi-assistant:codex/macos-deployment-target-12
Sep 17, 2026
Merged

satoshi-szk merged 1 commit into
novonotes:novonotes-internalfrom
satoshi-assistant:codex/macos-deployment-target-12

Conversation

@satoshi-assistant

Copy link
Copy Markdown
Contributor

Why

Xcode 27 and newer reject any deployment target below 12.0 when configuring a project. Because the wrapper default was 11.0, every VST3/AU configure step fails on an up-to-date toolchain with:

error: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 11.0, but the range of supported deployment target versions is 12.0 to 27.0.x.

What

  • Raise the default to 12.0 in the Rust build operations and in clap_wrapper_builder/CMakeLists.txt.
  • Centralize the value in wrac_build_ops::util::macos_deployment_target() so the Rust build and the wrapper configure cannot disagree about the minimum macOS version.
  • Drop the MACOSX_DEPLOYMENT_TARGET override from the CI workflow. It duplicated the default and silently pinned an older minimum whenever the code default changed.

MACOSX_DEPLOYMENT_TARGET still overrides the default, so callers that need a different floor keep working.

Verification

  • cargo clippy -p wrac_build_ops --all-targets -- -D warnings
  • cargo test -p wrac_build_ops
  • Built a VST3 and an AU wrapper against this branch on Xcode 27; both succeeded and the resulting bundles report minos 12.0.

Xcode 27 and newer reject any deployment target below 12.0 when configuring a project, so every wrapper configure step fails on an up-to-date toolchain.

The 11.0 default was duplicated across the Rust build operations, the wrapper CMakeLists, and CI environment variables. Centralize it in one helper so the wrappers cannot disagree about the minimum macOS version, and drop the CI override because it silently pinned the old value.
@satoshi-szk
satoshi-szk merged commit d3b9294 into novonotes:novonotes-internal Sep 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants