Repository navigation
Raise the default macOS deployment target to 12.0 - #158
Merged
satoshi-szk merged 1 commit intoSep 17, 2026
Merged
satoshi-szk merged 1 commit into
satoshi-szk merged 1 commit into
Conversation
Xcode 27 and newer reject any deployment target below 12.0 when configuring a project, so every wrapper configure step fails on an up-to-date toolchain. The 11.0 default was duplicated across the Rust build operations, the wrapper CMakeLists, and CI environment variables. Centralize it in one helper so the wrappers cannot disagree about the minimum macOS version, and drop the CI override because it silently pinned the old value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Xcode 27 and newer reject any deployment target below 12.0 when configuring a project. Because the wrapper default was 11.0, every VST3/AU configure step fails on an up-to-date toolchain with:
What
clap_wrapper_builder/CMakeLists.txt.wrac_build_ops::util::macos_deployment_target()so the Rust build and the wrapper configure cannot disagree about the minimum macOS version.MACOSX_DEPLOYMENT_TARGEToverride from the CI workflow. It duplicated the default and silently pinned an older minimum whenever the code default changed.MACOSX_DEPLOYMENT_TARGETstill overrides the default, so callers that need a different floor keep working.Verification
cargo clippy -p wrac_build_ops --all-targets -- -D warningscargo test -p wrac_build_opsminos 12.0.