Skip to content

fix(src): commonGetPlaintext: prevent js execution - #101

Merged
furcan merged 15 commits into
mainfrom
fix/plain-text
Oct 21, 2026
Merged

furcan merged 15 commits into
mainfrom
fix/plain-text

Conversation

@furcan

@furcan furcan commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Context

#100

  • The issue described above very-well in detail.

Overpromised plainText option on all modules still allows JS execution.

Considered options

  1. Fix it, together with bare-minimum changes, and considering supported browsers, regardless the Internet Explorer is dead.
  2. Drop the plainText option entirely, and document why dropped, and let the consumers to do the "must" HTML-sanitisation, especially if they use Notiflix as a "proxy" notification API to allowing their end-users to cast their own messages.

Decided option

  1. Fixing it.
    • Dropping the feature generally correct but will be a braking change that this library in LTS Maintenance mode, no need to increase the scope and impact.

Changes

  • src: fix: Notiflix.js: commonGetPlaintext: prevent js execution
  • Package/Dev/Build/Dist: bump a new version as 3.3.0

Screenshots

notiflix-issues-100

@furcan
furcan merged commit 939c543 into main Oct 21, 2026
1 check passed
@furcan
furcan deleted the fix/plain-text branch October 21, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plainText: true does not prevent HTML execution: messages are stripped and re-inserted via innerHTML (DOM XSS)

1 participant