Repository navigation
fix(src): commonGetPlaintext: prevent js execution - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#100
Overpromised
plainTextoption on all modules still allows JS execution.Considered options
plainTextoption entirely, and document why dropped, and let the consumers to do the "must" HTML-sanitisation, especially if they use Notiflix as a "proxy" notification API to allowing their end-users to cast their own messages.Decided option
Changes
Notiflix.js: commonGetPlaintext: prevent js execution3.3.0Screenshots