Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
|
Review requested:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #62672 +/- ##
==========================================
- Coverage 91.52% 89.78% -1.74%
==========================================
Files 354 699 +345
Lines 148921 216392 +67471
Branches 23352 41364 +18012
==========================================
+ Hits 136304 194296 +57992
- Misses 12354 14214 +1860
- Partials 263 7882 +7619
🚀 New features to boost your workflow:
|
|
As mentioned in my comments on the linked issue, I feel like it should be explicitly documented that this only drops permissions and does not close currently open file handles, sockets etc, that it is expected behaviour and is the app code's responsibility to close/release those if they are no longer required. |
Refs: #62223