test: add coverage for utility modules#718
Open
wilsonwangdev wants to merge 2 commits intonodejs:mainfrom
Open
test: add coverage for utility modules#718wilsonwangdev wants to merge 2 commits intonodejs:mainfrom
wilsonwangdev wants to merge 2 commits intonodejs:mainfrom
Conversation
Add tests for enforceArray, withExt, lazy, isPlainObject, deepMerge, and populate — all previously untested pure utility functions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
reviewed
Mar 26, 2026
avivkeller
reviewed
Mar 26, 2026
wilsonwangdev
force-pushed
the
test/utility-coverage
branch
from
bec8444 to
d1d0595
Compare
wilsonwangdev
force-pushed
the
test/utility-coverage
branch
from
d1d0595 to
b502f1f
Compare
wilsonwangdev
force-pushed
the
test/utility-coverage
branch
from
b502f1f to
d430e61
Compare
avivkeller
approved these changes
Mar 26, 2026
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
Are you an AI agent? While your implementation is fine, I feel like I'm interacting with a robot.
- Simplify enforceArray tests to two cases (array vs non-array) - Remove redundant multiple-substitutions test for populate
wilsonwangdev
force-pushed
the
test/utility-coverage
branch
from
d430e61 to
8798d90
Compare
Contributor
Author
I use cursor as my editor, it helps me a lot to do such work 😄 |
AugustinMauroy
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for 4 previously untested pure utility modules:
src/utils/array.mjs—enforceArray()(4 tests)src/utils/file.mjs—withExt()(4 tests)src/utils/misc.mjs—lazy(),isPlainObject(),deepMerge()(7 tests)src/utils/configuration/templates.mjs—populate()(4 tests)All 19 new tests follow existing conventions (
node:assert/strict,describe/it, co-located__tests__/directories).Validation
Check List
node --run testand all tests passed.node --run format&node --run lint.