Make Notebook.backup() crash-safe - #343
Open
Flerpharos wants to merge 1 commit into
Open
Conversation
Two defects in backup(): - The HTTP stream was opened before `path.parent.mkdir(...)`, which ran outside `with stream`; a mkdir failure (permissions, or a parent that is a file) leaked the response/connection until GC. - The destination was opened with "wb", truncating any existing archive immediately; a mid-download failure destroyed the previous good backup and left a corrupt partial at the destination. Create the directory inside `with stream:` (so the stream is always closed), and download to a NamedTemporaryFile in the destination directory, atomically `replace()`-ing it over the destination only after the download completes. On any failure the partial temp file is removed and the existing archive is left untouched. Fixes #342. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #342 (MED — data loss + resource leak; from the Codex audit). Two defects in
Notebook.backup():path.parent.mkdir(...)ran beforewith stream:. A mkdir failure (permissions, or a parent path component that is a file) skipped thewithblock, leaking the response/connection until GC."wb", truncating any existing file immediately; a mid-download failure left the previous good backup gone and a corrupt partial in its place.Fix
with stream:, so the stream is always closed even if mkdir fails.NamedTemporaryFilein the destination directory and atomicallyreplace()it over the destination only after the download completes. On any failure (includingKeyboardInterrupt) the partial temp file is removed and the existing archive is left untouched.Verification
New tests:
test_backup_interrupted_preserves_existing_archive(mid-stream failure → existing archive intact, no.partleft) andtest_backup_closes_stream_when_mkdir_fails(mkdir failure →response.close()called). Full suite 432 passed, 1 skipped; ruff/pyright clean.Fixes #342.
🤖 Generated with Claude Code