Fix move_to appending to unpopulated destination's _children - #337
Merged
Conversation
Guard the local _children append in move_to so it only runs when the destination is already populated, mirroring create(). When unpopulated, the next _ensure_populated() call replaces _children wholesale anyway, so appending first just leaves _children non-empty while _populated is still False, an inconsistent state discarded on the next fetch. Fixes #322 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322
move_towas appending the moved node todestination._childrenunconditionally, even whendestination._populatedwas False. Since the next_ensure_populated()call replaces_childrenwholesale, that append was pointless at best and left_childrennon-empty while_populatedwas still False in the meantime — an inconsistent internal state. The guard now only appends when the destination is already populated (mirroring howcreate()handles it), leaving population of an unpopulated destination to the next_ensure_populated()call.