QuickJS: fix unhandled rejection tracking in reused contexts#1087
Merged
Conversation
ngx_qjs_destroy() unregisters the host promise rejection tracker on the runtime, but ngx_qjs_clone() did not re-register it when a context was popped from the reuse queue. Every request served by a reused context then silently dropped unhandled rejections instead of reporting them, which also defeated any caller relying on ctx->rejected_promises.
github-project-automation
Bot
moved this from New
to In Review
in NGINX OSS Unified Workspace
github-project-automation
Bot
moved this from In Review
to Done
in NGINX OSS Unified Workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngx_qjs_destroy() unregisters the host promise rejection tracker on the runtime, but ngx_qjs_clone() did not re-register it when a context was popped from the reuse queue. Every request served by a reused context then silently dropped unhandled rejections instead of reporting them, which also defeated any caller relying on ctx->rejected_promises.