QuickJS: add missing btoa() and atob()#1084
Merged
Merged
Conversation
VadimZhestikov
previously approved these changes
Jun 24, 2026
github-project-automation
Bot
moved this from New
to In Progress
in NGINX OSS Unified Workspace
Contributor
Author
|
Applied fixes and implemented " algorithm strips all ASCII whitespace", and removed extra tmp allocation from original njs |
The functions implement the WHATWG btoa()/atob() global functions for the QuickJS engine, mirroring the built-in njs engine. Both engines decode forgiving-base64 in a single pass using a bit accumulator, without allocating a scratch buffer for the whitespace-stripped copy. The shared behaviour is corrected and aligned with WHATWG: - atob() strips all ASCII whitespace (TAB, LF, FF, CR, SPACE), not only SPACE; VT and NBSP are not ASCII whitespace and are rejected. - btoa() error text says "(> U+00FF)" to match the cp > 0xff check. The narrower njs-only btoa()/atob() unit tests are dropped in favor of test/btoa.t.js, which exercises both engines.
Contributor
Author
|
@VadimZhestikov Fixed assert() for size == 0 in js_malloc_rt() in QuickJS, for empty string output. |
github-project-automation
Bot
moved this from In Progress
to Done
in NGINX OSS Unified Workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions implement the WHATWG btoa()/atob() global functions for the QuickJS engine, mirroring the built-in njs engine.
The narrower njs-only btoa()/atob() unit tests are dropped in favor of test/btoa.t.js, which exercises both engines.